Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix OutputBlockBuffer to avoid repeatedly copying remainder block #48266

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexeykudinkin
Copy link
Contributor

Why are these changes needed?

Currently, inside OutputBlockBuffer we're

  1. Repeatedly copying remainder of the original block, bringing total # of bytes copied to O(N^2) (where N is the size of the original block)
  2. Creating potentially very large blocks (like in [Data] Cannot load large JSONL file #48236) that could overflow underlying Arrow data types.

This change addresses both of these issues, by establishing following protocol where

  1. Finalized target blocks are copied, while
  2. Remainder block is NOT (therefore continuing referencing original block)

Addresses #48236

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Oct 25, 2024
@alexeykudinkin alexeykudinkin linked an issue Oct 25, 2024 that may be closed by this pull request
@pcmoritz
Copy link
Contributor

Great find! So my understanding is that .slice here

view = _copy_table(view)
concatenated all the chunks in the ChunkedArray and that led to the overflow? :)

@pcmoritz
Copy link
Contributor

There are some test failure but this seems like the right fix :)

Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
@alexeykudinkin
Copy link
Contributor Author

concatenated all the chunks in the ChunkedArray and that led to the overflow? :)

Correct. And we'd avoid copying here as well as it's absolutely unnecessary.

Signed-off-by: Alexey Kudinkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Cannot load large JSONL file
2 participants