[core] Introduce IOContextProvider and its Policy #48231
+283
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
|
Thanks @dayshah for the valuable suggestions! Applied most, except for one: we still need the unique_ptr because the InstrumentedIOContextWithThread has no default ctor so we can't easily init it in an array. |
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
Oct 25, 2024
src/ray/gcs/gcs_server/gcs_server.h
Outdated
| @@ -206,18 +207,12 @@ class GcsServer { | |||
|
|
|||
| void TryGlobalGC(); | |||
|
|
|||
| IoContextProvider<GcsServerIoContextPolicy> io_context_provider_; | |||
There was a problem hiding this comment.
Should we introduce a factory method in a separate file like https://github.com/ray-project/ray/blob/master/python/ray/serve/_private/default_impl.py
There was a problem hiding this comment.
hmm I think that'd be too elaborate since the only difference is this 1 line
There was a problem hiding this comment.
ok, let's keep as it is and revisit it if it will cause merge conflicts.
jjyao
reviewed
Oct 25, 2024
Signed-off-by: Ruiyang Wang <[email protected]>
rynewang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GcsServer manages several IO Contexts and their threads, and hard codes which class uses which IO Context. This is not flexible in that we can't easily declare another IO Context and adapt some classes without a pervasive code change.
Introduces an IoContextProvider that manages IO Contexts based on a static, compile-time Policy, whose author can determine class-IO Context mapping. This way we can change the mappings in a central place without big chunk of changes everywhere.