Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add more infos to each breakpoint #48202

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

rynewang
Copy link
Contributor

@rynewang rynewang commented Oct 22, 2024

Ray debugger CLI (ray debug) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which.

Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in ray debug these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints.

Closes #48129.

Copy link
Contributor

@ruisearch42 ruisearch42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change.

Question: should we make this configurable at some point? Sometimes people may not need all these and it could be too verbose?

python/ray/scripts/scripts.py Outdated Show resolved Hide resolved
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
Copy link
Contributor Author

verbose mode added.

@rynewang rynewang assigned jjyao and unassigned jjyao Oct 22, 2024
@rynewang rynewang enabled auto-merge (squash) October 22, 2024 22:27
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 22, 2024
Copy link
Contributor

@ruisearch42 ruisearch42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rynewang rynewang merged commit 360ca49 into ray-project:master Oct 23, 2024
6 of 7 checks passed
akyang-anyscale pushed a commit to akyang-anyscale/ray that referenced this pull request Oct 23, 2024
Ray debugger CLI (`ray debug`) is useful but when you have multiple
tasks in the breakpoint, and they are of the same task function, one can
have difficulties understanding which is which.

Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info
so in `ray debug` these IDs show up in the breakpoint selection menu.
This helps users disambiguate between active breakpoints.

The new fields are gated by `-v` or `--verbose`.

Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: akyang-anyscale <[email protected]>
@rynewang rynewang deleted the ray-debugger-more-infos branch October 23, 2024 18:24
@rynewang rynewang assigned rynewang and unassigned ruisearch42 Oct 24, 2024
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
Ray debugger CLI (`ray debug`) is useful but when you have multiple
tasks in the breakpoint, and they are of the same task function, one can
have difficulties understanding which is which.

Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info
so in `ray debug` these IDs show up in the breakpoint selection menu.
This helps users disambiguate between active breakpoints.

The new fields are gated by `-v` or `--verbose`.

Signed-off-by: Ruiyang Wang <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
Ray debugger CLI (`ray debug`) is useful but when you have multiple
tasks in the breakpoint, and they are of the same task function, one can
have difficulties understanding which is which.

Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info
so in `ray debug` these IDs show up in the breakpoint selection menu.
This helps users disambiguate between active breakpoints.

The new fields are gated by `-v` or `--verbose`.

Signed-off-by: Ruiyang Wang <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
Ray debugger CLI (`ray debug`) is useful but when you have multiple
tasks in the breakpoint, and they are of the same task function, one can
have difficulties understanding which is which.

Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info
so in `ray debug` these IDs show up in the breakpoint selection menu.
This helps users disambiguate between active breakpoints.

The new fields are gated by `-v` or `--verbose`.

Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core][Debugger] Info about node IP for each breakpoint is not exposed in Ray Debugger
3 participants