-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add more infos to each breakpoint #48202
[core] Add more infos to each breakpoint #48202
Conversation
Signed-off-by: Ruiyang Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change.
Question: should we make this configurable at some point? Sometimes people may not need all these and it could be too verbose?
Signed-off-by: Ruiyang Wang <[email protected]>
verbose mode added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Ray debugger CLI (`ray debug`) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which. Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in `ray debug` these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints. The new fields are gated by `-v` or `--verbose`. Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: akyang-anyscale <[email protected]>
Ray debugger CLI (`ray debug`) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which. Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in `ray debug` these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints. The new fields are gated by `-v` or `--verbose`. Signed-off-by: Ruiyang Wang <[email protected]>
Ray debugger CLI (`ray debug`) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which. Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in `ray debug` these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints. The new fields are gated by `-v` or `--verbose`. Signed-off-by: Ruiyang Wang <[email protected]>
Ray debugger CLI (`ray debug`) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which. Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in `ray debug` these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints. The new fields are gated by `-v` or `--verbose`. Signed-off-by: Ruiyang Wang <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Ray debugger CLI (
ray debug
) is useful but when you have multiple tasks in the breakpoint, and they are of the same task function, one can have difficulties understanding which is which.Add "Node ID", "Worker ID", "Actor ID", "Task ID" to the breakpoint info so in
ray debug
these IDs show up in the breakpoint selection menu. This helps users disambiguate between active breakpoints.Closes #48129.