-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][tune][train] Update release test compute configs to not schedule work on head node #48103
Merged
justinvyu
merged 9 commits into
ray-project:master
from
justinvyu:deflake_tune_train_release_test
Oct 29, 2024
Merged
[ci][tune][train] Update release test compute configs to not schedule work on head node #48103
justinvyu
merged 9 commits into
ray-project:master
from
justinvyu:deflake_tune_train_release_test
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
rkooo567
approved these changes
Oct 21, 2024
hongpeng-guo
approved these changes
Oct 21, 2024
…ake_tune_train_release_test
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…ake_tune_train_release_test
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
… work on head node (ray-project#48103) This PR updates the compute configs for benchmark release tests to not schedule workers onto the head node. This reflects the best practice not to schedule heavy work on the head node for cluster stability. --------- Signed-off-by: Justin Yu <[email protected]>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…schedule work on head node" (ray-project#48321) Reverts ray-project#48103
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
… work on head node (ray-project#48103) This PR updates the compute configs for benchmark release tests to not schedule workers onto the head node. This reflects the best practice not to schedule heavy work on the head node for cluster stability. --------- Signed-off-by: Justin Yu <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…schedule work on head node" (ray-project#48321) Reverts ray-project#48103 Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
… work on head node (ray-project#48103) This PR updates the compute configs for benchmark release tests to not schedule workers onto the head node. This reflects the best practice not to schedule heavy work on the head node for cluster stability. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…schedule work on head node" (ray-project#48321) Reverts ray-project#48103 Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates the compute configs for benchmark release tests to not schedule workers onto the head node. This reflects the best practice not to schedule heavy work on the head node for cluster stability.
Test results for the flaky
air_benchmark_tune_torch_mnist.aws
:Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.