Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes.md #48082

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Update kubernetes.md #48082

merged 3 commits into from
Nov 15, 2024

Conversation

mohitjain2504
Copy link
Contributor

@mohitjain2504 mohitjain2504 commented Oct 17, 2024

Why are these changes needed?

Fixed typo

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: mohitjain2504 <[email protected]>
@jcotant1
Copy link
Collaborator

Hey @GeneDer is this one ready to go?

@GeneDer
Copy link
Contributor

GeneDer commented Nov 13, 2024

Hey @GeneDer is this one ready to go?

Nope

@GeneDer GeneDer mentioned this pull request Nov 15, 2024
8 tasks
Co-authored-by: Gene Der Su <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Nov 15, 2024
@richardliaw richardliaw enabled auto-merge (squash) November 15, 2024 21:53
@richardliaw richardliaw merged commit 3435c25 into ray-project:master Nov 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants