[data] Add mosaicml-streaming to BYOD requirements for release testing #37896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
approved these changes
Jul 28, 2023
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with python 3.8 | |||
| # This file is autogenerated by pip-compile with python 3.9 | |||
There was a problem hiding this comment.
oh, you should compile this with python 3.8, not 3.9
| @@ -12,6 +12,7 @@ gym[atari] | |||
| importlib-metadata | |||
| lightgbm | |||
| memray | |||
| mosaicml-streaming | |||
There was a problem hiding this comment.
this should be added to requirements_byod_ml_3.8.in since your test uses ray-ml image
can-anyscale
requested changes
Jul 28, 2023
Signed-off-by: Stephanie Wang <[email protected]>
stephanie-wang
force-pushed
the
add-test-dep
branch
from
d772a62 to
f5d2863
Compare
Ah thanks. Can you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a dep required by #37610.