[Core] Fix the accidental protobuf backward incompatible changes (#37… #37826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#37650) Move the JobTableData to "backward compatibility required" section since it is. However, we should generally be careful when we modify the protobuf to keep the backward compatibility. https://github.com/ray-project/ray/pull/35188/files#diff-66e7c4b1cbb0a6ce505e17964332b0e4d26631f291bcbabd221d13fa09707d90 -> Fix the protobuf compatibility by keep the driver_ip_address and add a new field driver_address at the end of the protobuf Append fields instead of adding in the middle. To do this, we move the field is_running_tasks to the end. We also mark the old address field as deprecated in a comment. The resulting protobuf is backwards compatible with Ray 2.5.1 and any prior version, and breaks compatibility with Ray 2.6.0 and Ray 2.6.1. It's not possible to be backwards compatible with both simultaneously. --------- Signed-off-by: SangBin Cho <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]> Co-authored-by: Archit Kulkarni <[email protected]>
architkulkarni
requested review from
a team,
wuisawesome,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz and
raulchen
as code owners
architkulkarni
added
release-blocker
zhe-thoughts
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…650)
Cherry pick of #37650 to the release branch.
Move the JobTableData to "backward compatibility required" section since it is. However, we should generally be careful when we modify the protobuf to keep the backward compatibility. https://github.com/ray-project/ray/pull/35188/files#diff-66e7c4b1cbb0a6ce505e17964332b0e4d26631f291bcbabd221d13fa09707d90 -> Fix the protobuf compatibility by keep the driver_ip_address and add a new field driver_address at the end of the protobuf Append fields instead of adding in the middle. To do this, we move the field is_running_tasks to the end. We also mark the old address field as deprecated in a comment.
The resulting protobuf is backwards compatible with Ray 2.5.1 and any prior version, and breaks compatibility with Ray 2.6.0 and Ray 2.6.1. It's not possible to be backwards compatible with both simultaneously.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.