Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] De-flake doctests #37743

Merged
merged 64 commits into from
Jul 26, 2023
Merged

[Docs] De-flake doctests #37743

merged 64 commits into from
Jul 26, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jul 25, 2023

Why are these changes needed?

This PR fixes three flaky examples.

Flaky example #1

This example is flaky because multiple examples write to /tmp/iris. In this case, there can be more than two files in the directory.

.. testcode::

    import os

    transformed_ds.write_parquet("/tmp/iris")

    print(sorted(os.listdir("/tmp/iris")))

.. testoutput::

    ['..._000000.parquet', '..._000001.parquet']

Flaky example #2

This example might produce output if the model weights aren't already downloaded.

        .. testcode::

            from ray.train.tensorflow import TensorflowCheckpoint
            import tensorflow as tf

            model = tf.keras.applications.resnet.ResNet101()
            checkpoint = TensorflowCheckpoint.from_model(model)

Flaky examples #3

If this test is re-run, it fails because "example.db" isn't cleaned up.

        .. testcode::

            import sqlite3

            import ray

            # Create a simple database
            connection = sqlite3.connect("example.db")
            connection.execute("CREATE TABLE movie(title, year, score)")

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bveeramani and others added 30 commits November 21, 2022 21:00
Signed-off-by: Balaji Veeramani <[email protected]>
This reverts commit de05655.

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as draft July 25, 2023 00:04
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 25, 2023
@bveeramani bveeramani marked this pull request as ready for review July 25, 2023 18:07
@c21 c21 merged commit 431d280 into ray-project:master Jul 26, 2023
@bveeramani bveeramani mentioned this pull request Jul 26, 2023
8 tasks
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: NripeshN <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants