-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global logging format changes #32741
Global logging format changes #32741
Conversation
f0e2032
to
341b631
Compare
81a3df1
to
3941de4
Compare
Failing tests
|
9e0df01
to
c564fdb
Compare
Please add me to the assignee section! |
☝️ Sorry about that! I saw your name in the assignee section, I should have added you to the reviewers as well! |
faba24c
to
487b0a3
Compare
Rebased onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests? We should make sure
- The context is properly printed within each library
- make sure the logging_level and logging_format works after this PR
I will also play with this log once I come back from OOO (next Mon)
026c746
to
8454bef
Compare
a5cbc5b
to
0209f19
Compare
Signed-off-by: pdmurray <[email protected]>
Signed-off-by: pdmurray <[email protected]>
0209f19
to
aec5702
Compare
Adter manual bisection, I think this PR may be causing the "Documentation" tests to fail. The failure was previously masked by an actual failing doctest, but after this commit, actor outputs clutter the doctests and lead to mismatches in expected and actual output. Let's see if reverting fixes these problems. Reverts #32741
This PR changes how the logging configuration for Ray is set, and changes the format of log messages. After a discussion with @rkooo567 we've decided to split the logging changes into multiple PRs. This is the first in a series which makes changes to library-level logging code for Ray. Signed-off-by: elliottower <[email protected]>
Adter manual bisection, I think this PR may be causing the "Documentation" tests to fail. The failure was previously masked by an actual failing doctest, but after this commit, actor outputs clutter the doctests and lead to mismatches in expected and actual output. Let's see if reverting fixes these problems. Reverts ray-project#32741 Signed-off-by: elliottower <[email protected]>
This PR changes how the logging configuration for Ray is set, and changes the format of log messages. After a discussion with @rkooo567 we've decided to split the logging changes into multiple PRs. This is the first in a series which makes changes to library-level logging code for Ray. Signed-off-by: Jack He <[email protected]>
Adter manual bisection, I think this PR may be causing the "Documentation" tests to fail. The failure was previously masked by an actual failing doctest, but after this commit, actor outputs clutter the doctests and lead to mismatches in expected and actual output. Let's see if reverting fixes these problems. Reverts ray-project#32741 Signed-off-by: Jack He <[email protected]>
#32741 accidentally removes the logging_format parameter from the setup_logging function. This PR overwrites the formatters for all default handlers. Signed-off-by: kaihsun <[email protected]>
Why are these changes needed?
This PR changes how the logging configuration for Ray is set, and changes the format of log messages.
After a discussion with @rkooo567 we've decided to split the logging changes into multiple PRs. This is the first in a series which makes changes to library-level logging code for Ray.
Changes
ray/log.py
.ray/__init__.py
at the top of the module. Subsequent calls to the configuration are ignored.ray.rllib
is configured at the WARN level, to address Revert "Simplify logging configuration. (#30863)" #31858. With this change,Revert "Simplify logging configuration. (#30863)" #31858 can be reverted, again simplifying and consolidating logging configuration.
test_output.py::test_logger_config
to test only the logger config, not launch a ray cluster. The test was failing intermittently, I think due to a race condition between the launch of the cluster and the reading of the subprocess's stdout, and anyway it wasn't necessary to callray.init
here to check that logging was configured correctly.python/ray/tune/tests/test_commands.py::test_ls_with_cfg
to test the underlying data, not what gets printed to stdout (which has changed with the new logging system).ray.tune.automl.search_policy.AutoMLSearcher.on_trial_complete
, which in certain cases emits a logging message which tries to format aNoneType
into a%f
during log message formatting. This was a previously-undetected bug which showed up because the default log level is nowINFO
. This fixes a test that was failing intest_automl_searcher.py::AutoMLSearcherTest
.Related issue number
Partially addresses #30005.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.