Fixes for the new bulk execution backend #31884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianoaix <[email protected]>
jianoaix
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
c21
as code owners
ericl
reviewed
Jan 24, 2023
| # TODO(https://github.com/ray-project/ray/issues/31145): re-enable | ||
| # after the segfault bug is fixed. | ||
| if DatasetContext.get_current().new_execution_backend: | ||
| return |
There was a problem hiding this comment.
Move to a separate file instead of disabling.
There was a problem hiding this comment.
That doesn't work either for this test, bazel still failed it.
There was a problem hiding this comment.
I think if you move this into a separate file, you can also remove the ray.shutdown() code below. That should avoid restarting Ray entirely.
There was a problem hiding this comment.
It failed (bazel test python/ray/data:tests/test_pipeline_incremental_take locally) still, but the CI test (which uses bazel) passed, didn't find out why.
There was a problem hiding this comment.
Maybe there was another Ray running locally or something.
ericl
added
the
@author-action-required
jianoaix
added
@author-action-required
jianoaix
removed
the
@author-action-required
ericl
approved these changes
Jan 24, 2023
|
@ericl tests passing, ready to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To enable the new bulk execution backend: #30903
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.