Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] temporary stop testing python grpcio prerelease package #31873

Merged
merged 2 commits into from
Jan 24, 2023
Merged

[Core] temporary stop testing python grpcio prerelease package #31873

merged 2 commits into from
Jan 24, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jan 23, 2023 •
edited
Loading

Why are these changes needed?

we test grpcio pre release to catch early regressions. we caught the latest prerelease is problematic (grpc/grpc#31885). To get a better signal, let's temporary stop testing grpcio prerelease until it's fixed.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review January 23, 2023 23:25
@scv119 scv119 changed the title [Core] temporary stop testing python grpc prerelease package [Core] temporary stop testing python grpcio prerelease package Jan 23, 2023
cadedaniel
cadedaniel approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad we have this to catch issues!

rkooo567
rkooo567 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we create an issue to reenable it?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 23, 2023
rickyyx
rickyyx approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scv119 scv119 merged commit d28007d into ray-project:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@rickyyx rickyyx rickyyx approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

Assignees

@cadedaniel cadedaniel

@rickyyx rickyyx

@rkooo567 rkooo567

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scv119 @cadedaniel @rickyyx @rkooo567