[core] Migrate many_nodes_actor_tests to new cloud. #31863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
fishbone
force-pushed
the
large-scale-nightly
branch
from
572ce8b
to
2a86f62
Compare
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
fishbone
changed the title
fishbone
requested review from
krfricke,
rkooo567 and
simon-mo
as code owners
Signed-off-by: Yi Cheng <[email protected]>
|
Given there is regression in both infra and oss side, I'll adjust the number later. |
rkooo567
approved these changes
Jan 24, 2023
| @@ -85,7 +87,12 @@ def run_prepare_command( | |||
| Command runners may choose to run this differently than the | |||
| test command. | |||
| """ | |||
| return self.run_command(command, env, timeout) | |||
| return exponential_backoff_retry( | |||
There was a problem hiding this comment.
Somehow in the new stack it needs waiting for a while (1-3s) before it's ready to be used
rkooo567
added
the
@author-action-required
The infra can't start 2k nodes and hangs and oss ray somehow GCS disappear. :( |
|
can you run the release test before merging it? |
|
@rkooo567 I triggered the test hours ago (https://buildkite.com/ray-project/release-tests-pr/builds/26327#0185e53f-d293-4e2a-a34b-b6aa149e30ab) but still pending :( |
|
passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR make the test run with the new cloud to prevent regression.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.