Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Clean up some algorithm.py config dict uses (replace by config objects) AND erroneous log messages #31854

Merged
merged 5 commits into from
Jan 25, 2023
Merged

[RLlib] Clean up some algorithm.py config dict uses (replace by config objects) AND erroneous log messages #31854

merged 5 commits into from
Jan 25, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 23, 2023 •
edited
Loading

Signed-off-by: sven1977 [email protected]

Clean up some algorithm.py config dict uses (replace by config objects) AND erroneous log messages

  • When evaluation_parallel_to_training=False and enable_async_evaluation=False, Algorithm should NOT log that evaluation is happening in parallel.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
b9fb440 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 assigned sven1977 and kouroshHakha and unassigned sven1977 Jan 23, 2023
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
dc93f14 
…rithm_cleanup_config_and_some_log_msg
@sven1977
LINT
9bdb690 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
f47ad79 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
f44becb 
…rithm_cleanup_config_and_some_log_msg

Signed-off-by: sven1977 <[email protected]>

# Conflicts:
#	rllib/algorithms/algorithm.py
@sven1977 sven1977 merged commit 477910b into ray-project:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@kouroshHakha kouroshHakha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @kouroshHakha