Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/N][Advanced timeline] Include events/profiling events to the ray list tasks #31776

Merged
merged 11 commits into from
Jan 23, 2023

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Jan 19, 2023

Why are these changes needed?

This PR

  1. changes scheduling_state -> state, which allows us to render state count from the frontend (it is also consistent with other schema).
  2. Add duration to the frontend.
  3. Add profile / regular events to the task state API.
  4. Support source side filtering for job id

There are remaining work in the follow up

  1. Replace timeline implementation to use task API
  2. Implement timeline frontend.
  3. Display events / profile events from the dashboard/state API in a better format.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: SangBin Cho <[email protected]>
Signed-off-by: SangBin Cho <[email protected]>
Signed-off-by: SangBin Cho <[email protected]>
Signed-off-by: SangBin Cho <[email protected]>
Signed-off-by: SangBin Cho <[email protected]>
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/ray/experimental/state/common.py Outdated Show resolved Hide resolved
Signed-off-by: SangBin Cho <[email protected]>
@rkooo567 rkooo567 requested a review from a team as a code owner January 20, 2023 13:26
@rkooo567 rkooo567 merged commit 228b87f into ray-project:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants