Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Deprecations for 2.3 #31763

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Jan 19, 2023

Signed-off-by: amogkam [email protected]

Fully removes APIs that were deprecated in 2.1.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <[email protected]>
@amogkam amogkam changed the title [Train] Deprecations for 2.3 [AIR] Deprecations for 2.3 Jan 19, 2023
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: amogkam <[email protected]>
@amogkam amogkam merged commit 91b632b into ray-project:master Jan 19, 2023
@amogkam amogkam deleted the 2-3-deprecations branch January 19, 2023 23:08
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
Signed-off-by: amogkam [email protected]

Fully removes APIs that were deprecated in 2.1.

Signed-off-by: Andrea Pisoni <[email protected]>
wuisawesome added a commit that referenced this pull request Jan 23, 2023
wuisawesome pushed a commit that referenced this pull request Jan 23, 2023
wuisawesome added a commit that referenced this pull request Jan 23, 2023
amogkam pushed a commit that referenced this pull request Jan 23, 2023
amogkam added a commit that referenced this pull request Jan 24, 2023
#31763 removes Checkpoint.from_object_ref, but doesn't remove the now-unused Checkpoint._object_ref. This PR cleans up the dead code.

Signed-off-by: amogkam <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Co-authored-by: amogkam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants