-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIR] Deprecations for 2.3 #31763
Merged
Merged
[AIR] Deprecations for 2.3 #31763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
amogkam
requested review from
clarkzinzow,
jiaodong,
Yard1,
bveeramani and
matthewdeng
as code owners
January 19, 2023 00:37
Signed-off-by: amogkam <[email protected]>
bveeramani
reviewed
Jan 19, 2023
bveeramani
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yard1
approved these changes
Jan 19, 2023
8 tasks
Signed-off-by: amogkam <[email protected]>
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
Signed-off-by: amogkam [email protected] Fully removes APIs that were deprecated in 2.1. Signed-off-by: Andrea Pisoni <[email protected]>
wuisawesome
added a commit
that referenced
this pull request
Jan 23, 2023
This reverts commit 91b632b.
wuisawesome
pushed a commit
that referenced
this pull request
Jan 23, 2023
wuisawesome
added a commit
that referenced
this pull request
Jan 23, 2023
amogkam
added a commit
that referenced
this pull request
Jan 24, 2023
#31763 removes Checkpoint.from_object_ref, but doesn't remove the now-unused Checkpoint._object_ref. This PR cleans up the dead code. Signed-off-by: amogkam <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: amogkam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: amogkam [email protected]
Fully removes APIs that were deprecated in 2.1.
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.