[core] Use KVStoreClient for internal kv. #31747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
scv119
approved these changes
Jan 21, 2023
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
The current implementation of KVStoreClient is wrong. It's not using the table and namespace correctly. This PR fixed this and migrate the old kv manager to the new ones. Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yi Cheng [email protected]
Why are these changes needed?
The current implementation of KVStoreClient is wrong. It's not using the table and namespace correctly. This PR fixed this and migrate the old kv manager to the new ones.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.