Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use an agent-id rather than the process PID (#24968)" #25342

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Jun 1, 2022

This reverts commit 02f220b.

Why are these changes needed?

Looks like this commit makes test_ray_shutdown way more flaky. cc @mattip for further investigation after revert
Screen Shot 2022-05-31 at 11 14 48 PM

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 merged commit 3385d19 into ray-project:master Jun 1, 2022
@rkooo567
Copy link
Contributor Author

rkooo567 commented Jun 1, 2022

@mattip please follow up!

@rkooo567
Copy link
Contributor Author

rkooo567 commented Jun 1, 2022

Turns out this is not related to the flakiness. I will re-revert. cc @mattip @scv119 This is the next candidate. #24747

rkooo567 added a commit to rkooo567/ray that referenced this pull request Jun 1, 2022
fishbone pushed a commit that referenced this pull request Jun 1, 2022
)

Turns out #25342 wasn't the root cause of the ray shutdown flakiness. I realized there's another PR that could affect this test suite. Let's try reverting it and see if things get better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants