Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Use protobuf < 4.0 in py. #25211

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

Test failed due to protobuf version problem:

(raylet) More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
  | (raylet) [2022-05-26 01:52:27,562 E 10316 10316] (raylet) worker_pool.cc:498: Some workers of the worker process(11044) have not registered within the timeout. The process is dead, probably it crashed during start.
  | (raylet) Traceback (most recent call last):
  | (raylet)   File "/ray/python/ray/workers/default_worker.py", line 8, in <module>
  | (raylet)     import ray
  | (raylet)   File "/ray/python/ray/__init__.py", line 115, in <module>
  | (raylet)     import ray._raylet  # noqa: E402
  | (raylet)   File "python/ray/_raylet.pyx", line 116, in init ray._raylet
  | (raylet)   File "/ray/python/ray/exceptions.py", line 7, in <module>
  | (raylet)     from ray.core.generated.common_pb2 import RayException, Language, PYTHON
  | (raylet)   File "/ray/python/ray/core/generated/common_pb2.py", line 15, in <module>
  | (raylet)     from . import runtime_env_common_pb2 as src_dot_ray_dot_protobuf_dot_runtime__env__common__pb2
  | (raylet)   File "/ray/python/ray/core/generated/runtime_env_common_pb2.py", line 42, in <module>
  | (raylet)     serialized_options=None, json_name='packages', file=DESCRIPTOR,  create_key=_descriptor._internal_create_key),
  | (raylet)   File "/tmp/ray/session_2022-05-26_01-42-02_431980_9214/runtime_resources/conda/a6ff561ba9229e48b1e71b5dba39510e8d1ba907/lib/python3.7/site-packages/google/protobuf/descriptor.py", line 560, in __new__
  | (raylet)     _message.Message._CheckCalledFromGeneratedFile()
  | (raylet) TypeError: Descriptors cannot not be created directly.
  | (raylet) If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
  | (raylet) If you cannot immediately regenerate your protos, some other possible workarounds are:
  | (raylet)  1. Downgrade the protobuf package to 3.20.x or lower.
  | (raylet)  2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).-- Test timed out at 2022-05-26 01:55:19 UTC --

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone marked this pull request as ready for review May 26, 2022 04:55
@fishbone fishbone mentioned this pull request May 26, 2022
6 tasks
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this currently break CI completely

@richardliaw richardliaw merged commit 7fcea8a into ray-project:master May 26, 2022
krfricke pushed a commit to krfricke/ray that referenced this pull request May 27, 2022
@arokem arokem mentioned this pull request May 28, 2022
@ddelange
Copy link
Contributor

@amogkam is there any timeline for the release of this high-impact patch?

@ddelange
Copy link
Contributor

upstream issue ref protocolbuffers/protobuf#10051 (comment)

@pcmoritz
Copy link
Contributor

pcmoritz commented Jun 2, 2022

@ddelange It will be part of the Ray 1.13 release, which is due in the next couple of days :)

janblumenkamp added a commit to proroklab/rllib_differentiable_comms that referenced this pull request Jun 4, 2022
scv119 added a commit that referenced this pull request Oct 17, 2022
This upper bound was introduced in #25211 but the root cause is supposed be fixed by #25648.
scv119 added a commit to scv119/ray that referenced this pull request Oct 17, 2022
This upper bound was introduced in ray-project#25211 but the root cause is supposed be fixed by ray-project#25648.
rickyyx pushed a commit that referenced this pull request Oct 17, 2022
This upper bound was introduced in #25211 but the root cause is supposed be fixed by #25648.
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
This upper bound was introduced in ray-project#25211 but the root cause is supposed be fixed by ray-project#25648.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants