-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] Use protobuf < 4.0 in py. #25211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
krfricke
approved these changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this currently break CI completely
6 tasks
richardliaw
approved these changes
May 26, 2022
@amogkam is there any timeline for the release of this high-impact patch? |
upstream issue ref protocolbuffers/protobuf#10051 (comment) |
@ddelange It will be part of the Ray 1.13 release, which is due in the next couple of days :) |
janblumenkamp
added a commit
to proroklab/rllib_differentiable_comms
that referenced
this pull request
Jun 4, 2022
…th ray 1.13.0)
7 tasks
scv119
added a commit
that referenced
this pull request
Oct 17, 2022
scv119
added a commit
to scv119/ray
that referenced
this pull request
Oct 17, 2022
This upper bound was introduced in ray-project#25211 but the root cause is supposed be fixed by ray-project#25648.
7 tasks
rickyyx
pushed a commit
that referenced
this pull request
Oct 17, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
This upper bound was introduced in ray-project#25211 but the root cause is supposed be fixed by ray-project#25648. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Test failed due to protobuf version problem:
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.