Remove exporting symbols #22623
Merged
Remove exporting symbols #22623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashione
requested review from
mwtian,
fishbone,
ericl and
scv119
as code owners
ashione
force-pushed
the
remove-exporting-symbols
branch
from
61b2572
to
c7c8b31
Compare
ashione
force-pushed
the
remove-exporting-symbols
branch
from
c7c8b31
to
83e994a
Compare
|
Could you please fill the description in the PR? |
|
Thanks for the change! Can you update the description? |
scv119
approved these changes
Feb 25, 2022
jovany-wang
approved these changes
Feb 25, 2022
|
rllib:learning_tests_transformed_actions_pendulum_sac failure is unrelated, which also fails on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To hidden symbols of thirdparty library, this pull request reuses internal namespace that can be imported by any external native projects without side effects.
Besides, we suggest all of contributors to make sure it'd better use thirdparty library in ray scopes/namspaces and only ray::internal should be exported.
More details in #22526
Mobius has applied this change in ray-project/mobius#28.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.