Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[core] add runtime env info to task spec debug string (#20631)" #20668

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Revert "[core] add runtime env info to task spec debug string (#20631)" #20668

merged 1 commit into from
Nov 23, 2021

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Nov 23, 2021 •
edited
Loading

This reverts commit e9132ed.

Why are these changes needed?

Seems to break Windows build.

(07:46:25) ERROR: BUILD.bazel:406:11: Compiling src/ray/common/task/task_spec.cc failed: (Exit 2): cl.exe failed: error executing command

Screen Shot 2021-11-23 at 3 09 18 AM

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Contributor Author

cc @SongGuyang

@rkooo567
Copy link
Contributor Author

Emergency merge

@rkooo567 rkooo567 merged commit 720bca8 into ray-project:master Nov 23, 2021
@SongGuyang
Copy link
Contributor

@rkooo567 Got. Sorry for the break and thank you for the revert.

@rkooo567
Copy link
Contributor Author

@SongGuyang no worries! Everyone does mistakes haha. Let me know once you open the PR again :). I will approve it immediately!

@SongGuyang
Copy link
Contributor

OK!

SongGuyang added a commit to alipay/ant-ray that referenced this pull request Nov 24, 2021
@SongGuyang
Revert "Revert "[core] add runtime env info to task spec debug string (…
681820c 
…ray-project#20631)" (ray-project#20668)"

This reverts commit 720bca8.
rkooo567 pushed a commit that referenced this pull request Nov 25, 2021
@SongGuyang
Revert "Revert "[core] add runtime env info to task spec debug string (…
454b7bd 
…#20668)" (#20697)

## Why are these changes needed?
- fix compiling error and revert the revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@ericl ericl

@scv119 scv119

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rkooo567 @SongGuyang @krfricke @ericl @scv119