[BUGFIX]Transfer test fix #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…control Conflicts: streaming/src/channel/channel.cc streaming/src/test/mock_transfer_tests.cc
Co-authored-by: Qing Wang <[email protected]>
…obius into empty-message-flow-control
jovany-wang
approved these changes
Feb 18, 2022
|
|
||
| transfer_config_->Set(ConfigEnum::QUEUE_ID_VECTOR, input_ids); | ||
|
|
||
| last_fetched_queue_item_ = nullptr; | ||
| timer_interval_ = timer_interval; | ||
| last_message_ts_ = 0; | ||
| // NOTE(lingxuan.zlx): Last recived message timestamp is marked in current system time. |
| @@ -33,13 +33,15 @@ void DataReader::Init(const std::vector<ObjectID> &input_ids, | |||
| void DataReader::Init(const std::vector<ObjectID> &input_ids, | |||
| const std::vector<ChannelCreationParameter> &init_params, | |||
| int64_t timer_interval) { | |||
| STREAMING_LOG(INFO) << input_ids.size() << " queue to init."; | |||
| STREAMING_LOG(INFO) << "Reader " << input_ids.size() | |||
| << " queue to init, timer interval " << timer_interval; | |||
There was a problem hiding this comment.
Add = here to make it make understandable?
"Reader, input id size =" << input_ids.size() << "xxxx timer interval = " << timer_interval;
Sorry for this comments. you might point out what we can change these in next PR. This pr is planning to fix this previous ci failures. |
ashione
added a commit
that referenced
this pull request
Feb 21, 2022
* Flowcontrol on empty messages * mock queue empty message flow control * Update streaming/src/channel/channel.h Co-authored-by: Qing Wang <[email protected]> * convert -1 to uint64_t max * timer interval init * data reader timeout setting * fix empty message emit Co-authored-by: ashione <[email protected]> Co-authored-by: Qing Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock transfer multiple channel consumed test will fail to filter empty message.