[Bug] KubeRay operator failed to watch endpoint #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kevin85421
force-pushed
the
add-watch-endpoints
branch
from
50b27a9 to
352439d
Compare
jjyao
approved these changes
Apr 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
Getoperation in controller-runtime also requireswatchpermission. See kubernetes-sigs/controller-runtime#1156 for more details. This PR (1) adds thewatchpermission for the endpoints, and (2) improves the observability of the requests sent bycurlcommands so that users can log in to thecurlPod and check the response.I observed that many requests fail due to timeout, so I think there may be resource contention if we launch 20 curl processes simultaneously. Hence, this PR also adds
time.sleep(1)between each curl request.watchcause the RayService sample YAML tests to fail frequently if we don't addtime.sleep(1)?Related issue number
Closes #2073
Checks