-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix status update issue and redis port formatting issue #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subresource Status has been extracted to a separate API. use `client.Status().update()` instead Signed-off-by: Jiaxin Shan <[email protected]>
Carelessly use string() to covert the int value and this gives ASCII value which makes redis port incorrect. Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Fix status not updated issue Subresource Status has been extracted to a separate API. use `client.Status().update()` instead Signed-off-by: Jiaxin Shan <[email protected]> * Fix int conversion issue by using strconv.Itoa(i) Carelessly use string() to covert the int value and this gives ASCII value which makes redis port incorrect. Signed-off-by: Jiaxin Shan <[email protected]> * Fix inconsistent redis password in examples Signed-off-by: Jiaxin Shan <[email protected]>
ChristianZaccaria
pushed a commit
to ChristianZaccaria/kuberay
that referenced
this pull request
Apr 17, 2024
ChristianZaccaria
pushed a commit
to ChristianZaccaria/kuberay
that referenced
this pull request
Apr 17, 2024
ChristianZaccaria
pushed a commit
to ChristianZaccaria/kuberay
that referenced
this pull request
Apr 17, 2024
sutaakar
pushed a commit
to sutaakar/kuberay
that referenced
this pull request
Nov 15, 2024
…fication add slack notification changes
oksanabaza
pushed a commit
to oksanabaza/kuberay
that referenced
this pull request
Nov 25, 2024
oksanabaza
pushed a commit
to oksanabaza/kuberay
that referenced
this pull request
Nov 25, 2024
oksanabaza
pushed a commit
to oksanabaza/kuberay
that referenced
this pull request
Nov 28, 2024
oksanabaza
pushed a commit
to oksanabaza/kuberay
that referenced
this pull request
Dec 4, 2024
oksanabaza
pushed a commit
to oksanabaza/kuberay
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.