Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status update issue and redis port formatting issue #16

Merged
merged 3 commits into from
Sep 5, 2021

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 5, 2021

No description provided.

Subresource Status has been extracted to a separate API. use `client.Status().update()` instead

Signed-off-by: Jiaxin Shan <[email protected]>
Carelessly use string() to covert the int value and this gives ASCII value which makes redis port incorrect.

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan merged commit 881b59a into ray-project:master Sep 5, 2021
@Jeffwan Jeffwan deleted the fix_issues branch September 5, 2021 17:42
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* Fix status not updated issue

Subresource Status has been extracted to a separate API. use `client.Status().update()` instead

Signed-off-by: Jiaxin Shan <[email protected]>

* Fix int conversion issue by using strconv.Itoa(i)

Carelessly use string() to covert the int value and this gives ASCII value which makes redis port incorrect.

Signed-off-by: Jiaxin Shan <[email protected]>

* Fix inconsistent redis password in examples

Signed-off-by: Jiaxin Shan <[email protected]>
ChristianZaccaria pushed a commit to ChristianZaccaria/kuberay that referenced this pull request Apr 17, 2024
ChristianZaccaria pushed a commit to ChristianZaccaria/kuberay that referenced this pull request Apr 17, 2024
ChristianZaccaria pushed a commit to ChristianZaccaria/kuberay that referenced this pull request Apr 17, 2024
sutaakar pushed a commit to sutaakar/kuberay that referenced this pull request Nov 15, 2024
oksanabaza pushed a commit to oksanabaza/kuberay that referenced this pull request Nov 25, 2024
oksanabaza pushed a commit to oksanabaza/kuberay that referenced this pull request Nov 25, 2024
oksanabaza pushed a commit to oksanabaza/kuberay that referenced this pull request Nov 28, 2024
oksanabaza pushed a commit to oksanabaza/kuberay that referenced this pull request Dec 4, 2024
oksanabaza pushed a commit to oksanabaza/kuberay that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant