Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete_many functionality to object store #360

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Add delete_many functionality to object store #360

merged 10 commits into from
Oct 7, 2024

Conversation

yankevn
Copy link
Collaborator

@yankevn yankevn commented Oct 2, 2024

This change adds the delete_many functionality to object stores. This is necessary to cleanup the object store between rounds of compaction.

raghumdani
raghumdani reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@raghumdani raghumdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please address few comments.

deltacat/compute/compactor_v2/private/compaction_utils.py Outdated Show resolved Hide resolved
deltacat/compute/compactor_v2/utils/primary_key_index.py Outdated Show resolved Hide resolved
deltacat/io/file_object_store.py Outdated Show resolved Hide resolved
deltacat/io/file_object_store.py Outdated Show resolved Hide resolved
deltacat/io/file_object_store.py Outdated Show resolved Hide resolved
deltacat/io/memcached_object_store.py Outdated Show resolved Hide resolved
deltacat/io/ray_plasma_object_store.py Outdated Show resolved Hide resolved
deltacat/io/redis_object_store.py Outdated Show resolved Hide resolved
deltacat/io/s3_object_store.py Outdated Show resolved Hide resolved
dev-requirements.txt Show resolved Hide resolved
raghumdani
raghumdani reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@raghumdani raghumdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Couple more minor comments.

deltacat/compute/compactor_v2/private/compaction_utils.py Outdated Show resolved Hide resolved
deltacat/compute/compactor_v2/private/compaction_utils.py Outdated Show resolved Hide resolved
deltacat/io/memcached_object_store.py Show resolved Hide resolved
deltacat/io/ray_plasma_object_store.py Outdated Show resolved Hide resolved
deltacat/io/memcached_object_store.py Outdated Show resolved Hide resolved
deltacat/compute/compactor_v2/private/compaction_utils.py Show resolved Hide resolved
deltacat/io/file_object_store.py Outdated Show resolved Hide resolved
deltacat/io/object_store.py Outdated Show resolved Hide resolved
deltacat/io/s3_object_store.py Outdated Show resolved Hide resolved
@raghumdani
Copy link
Collaborator

Looks good overall. Be sure to test thoroughly before merging..

@yankevn yankevn merged commit fca5701 into main Oct 7, 2024
3 checks passed
@yankevn yankevn deleted the add_delete_many branch October 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghumdani raghumdani raghumdani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yankevn @raghumdani