Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom dns addr flag #399

Merged
merged 1 commit into from
Jul 17, 2024
Merged

add custom dns addr flag #399

merged 1 commit into from
Jul 17, 2024

Conversation

titanventura
Copy link
Contributor

@titanventura titanventura commented Jul 15, 2024 •
edited
Loading

Fixes #354

@titanventura
add custom dns addr flag
a547858 
Signed-off-by: titanventura <[email protected]>
@titanventura
Copy link
Contributor Author

please have a look @raviqqe

@raviqqe raviqqe enabled auto-merge (squash) July 17, 2024 12:02
@raviqqe
Copy link
Owner

raviqqe commented Jul 17, 2024

Thank you so much for the change!

@raviqqe raviqqe disabled auto-merge July 17, 2024 12:05
@raviqqe raviqqe merged commit 743a4e0 into raviqqe:main Jul 17, 2024
5 of 6 checks passed
@raviqqe
Copy link
Owner

raviqqe commented Jul 17, 2024

Can you test the main branch? I renamed the option --dns-resolver.

raviqqe
raviqqe reviewed Jul 17, 2024
View reviewed changes
fasthttp_http_client_factory.go
dialer := fasthttp.TCPDialer{
Concurrency: 1000,
Resolver: &net.Resolver{
PreferGo: true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason you enabled this option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think if we don't enable this option, it uses the DNS resolver of our operating system, I tried sniffing the DNS packets through wireshark, the custom dns resolver was used only if I turn on this flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at golang/go#35561 (comment)

Copy link
Owner

@raviqqe raviqqe Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I reverted it back. Can you test the main branch again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will do and get back to you !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @raviqqe just tested it, seems to be working fine

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 21, 2024
@tmeijn
build(deps): update raviqqe/muffet to v2.10.3
6f6ffd2 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [raviqqe/muffet](https://github.com/raviqqe/muffet) | patch | `v2.10.2` -> `v2.10.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>raviqqe/muffet (raviqqe/muffet)</summary>

### [`v2.10.3`](https://github.com/raviqqe/muffet/releases/tag/v2.10.3)

[Compare Source](raviqqe/muffet@v2.10.2...v2.10.3)

#### Changelog

-   [`a77feac`](raviqqe/muffet@a77feac) Bump golang.org/x/net from 0.26.0 to 0.27.0 ([#&#8203;397](raviqqe/muffet#397))
-   [`fe6757d`](raviqqe/muffet@fe6757d) Bump golang.org/x/net from 0.27.0 to 0.28.0 ([#&#8203;403](raviqqe/muffet#403))
-   [`1b33cb2`](raviqqe/muffet@1b33cb2) Bump golang.org/x/net from 0.28.0 to 0.29.0 ([#&#8203;405](raviqqe/muffet#405))
-   [`c11474c`](raviqqe/muffet@c11474c) Bump version ([#&#8203;409](raviqqe/muffet#409))
-   [`985b1a3`](raviqqe/muffet@985b1a3) Modify DNS resolver option ([#&#8203;400](raviqqe/muffet#400))
-   [`f2d4a37`](raviqqe/muffet@f2d4a37) Re-enable `PreferGo` flag for DNS resolver ([#&#8203;401](raviqqe/muffet#401))
-   [`eae612e`](raviqqe/muffet@eae612e) Update help test ([#&#8203;408](raviqqe/muffet#408))
-   [`743a4e0`](raviqqe/muffet@743a4e0) add custom dns addr flag ([#&#8203;399](raviqqe/muffet#399))
-   [`43aa9cc`](raviqqe/muffet@43aa9cc) doc: document non-contiguous status code ranges ([#&#8203;407](raviqqe/muffet#407))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviqqe raviqqe raviqqe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add custom DNS servers
2 participants
@titanventura @raviqqe