Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an argument to filter out certain HTTP error codes #291

Open
spkane opened this issue Mar 8, 2023 · 4 comments
Open

Provide an argument to filter out certain HTTP error codes #291

spkane opened this issue Mar 8, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@spkane
Copy link

spkane commented Mar 8, 2023

Make it possible to ignore a set of HTTP error codes, like -g 403,999.
@spkane
Copy link
Author

spkane commented Mar 8, 2023

there might be another approach to handling/fixing this, but this is primarily being mentioned do to URLs like:

https://www.linkedin.com/in/spkane/ (which always returns an HTTP 999 to muffet, despite being a valid URL) and
https://docs.aws.amazon.com/AmazonS3/latest/userguide/ServerLogs.html (which always returns an HTTP 403 to muffet, despite being a valid URL)

@spkane spkane mentioned this issue Mar 9, 2023
Open
@spkane
Copy link
Author

spkane commented Mar 9, 2023

Based on #292, being able to set some code to ignore and some to report/warn but not error on at a global level would be useful, in addition to eventually also being able to set this on a per-patter basis.

@raviqqe raviqqe added the enhancement New feature or request label Mar 10, 2023
@raviqqe raviqqe moved this to Todo in Muffet Mar 16, 2023
@raviqqe raviqqe added this to Muffet Mar 16, 2023
@raviqqe
Copy link
Owner

raviqqe commented Mar 16, 2023 •
edited
Loading

I also prefer a proposal in #292 to this because users can't know false positives when websites' behavior changes and error status codes are ignored globally. One concern of ignored status codes per pattern is their complexity...

@spkane
Copy link
Author

spkane commented Mar 17, 2023 •
edited
Loading

Agreed.

#292 basically built on this idea and came to me as I was trying to implement the scanner GitHub action into one of my website deployment processes.

@pmwmedia pmwmedia mentioned this issue Feb 22, 2024
Merged
raviqqe pushed a commit that referenced this issue Feb 28, 2024
@pmwmedia
Make accepted HTTP response status codes configurable (#364)
df4845c 
This pull request adds a new optional argument `--status-codes` to make
the accepted HTTP response status codes configurable and solves #189 and
#291.

I use muffet to check all links on https://tinylog.org/. However, some
websites (e.g. https://stackoverflow.com, https://www.baeldung.com, and
https://mkyong.com/) respond with status code 403 instead of 200 to
muffet. Therefore, I would like to accept 403 as valid HTTP response
status code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Muffet
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spkane @raviqqe