Remove time tracking (#278)

json_page_result_test.go

@@ -15,9 +15,8 @@ func TestMarshalErrorJSONPageResult(t *testing.T) {
 			"http://foo.com",
 			[]*successLinkResult{},
 			[]*errorLinkResult{
-				{"http://foo.com/bar", errors.New("baz"), 0},
+				{"http://foo.com/bar", errors.New("baz")},
 			},
-			0,
 		}, false))
 	assert.Nil(t, err)
 	cupaloy.SnapshotT(t, bs)
@@ -28,10 +27,9 @@ func TestMarshalSuccessJSONPageResult(t *testing.T) {
 		&pageResult{
 			"http://foo.com",
 			[]*successLinkResult{
-				{"http://foo.com/foo", 200, 0},
+				{"http://foo.com/foo", 200},
 			},
 			[]*errorLinkResult{},
-			0,
 		}, true))
 	assert.Nil(t, err)
 	cupaloy.SnapshotT(t, bs)

page_checker.go

@@ -1,9 +1,6 @@
 package main
 
-import (
-	"sync"
-	"time"
-)
+import "sync"
 
 type pageChecker struct {
 	fetcher       *linkFetcher
@@ -43,10 +40,9 @@ func (c *pageChecker) checkPage(p *page) {
 	ec := make(chan *errorLinkResult, len(us))
 	w := sync.WaitGroup{}
 
-	pageStart := time.Now()
 	for u, err := range us {
 		if err != nil {
-			ec <- &errorLinkResult{u, err, time.Since(time.Now())}
+			ec <- &errorLinkResult{u, err}
 			continue
 		}
 
@@ -55,14 +51,12 @@ func (c *pageChecker) checkPage(p *page) {
 		go func(u string) {
 			defer w.Done()
 
-			linkStart := time.Now()
 			status, p, err := c.fetcher.Fetch(u)
-			linkElapsed := time.Since(linkStart)
 
 			if err == nil {
-				sc <- &successLinkResult{u, status, linkElapsed}
+				sc <- &successLinkResult{u, status}
 			} else {
-				ec <- &errorLinkResult{u, err, linkElapsed}
+				ec <- &errorLinkResult{u, err}
 			}
 
 			if !c.onePageOnly && p != nil && c.linkValidator.Validate(p.URL()) {
@@ -72,7 +66,6 @@ func (c *pageChecker) checkPage(p *page) {
 	}
 
 	w.Wait()
-	pageElapsed := time.Since(pageStart)
 
 	close(sc)
 	close(ec)
@@ -89,7 +82,7 @@ func (c *pageChecker) checkPage(p *page) {
 		es = append(es, e)
 	}
 
-	c.results <- &pageResult{p.URL().String(), ss, es, pageElapsed}
+	c.results <- &pageResult{p.URL().String(), ss, es}
 }
 
 func (c *pageChecker) addPage(p *page) {

page_result.go

@@ -1,24 +1,19 @@
 package main
 
-import "time"
-
 type pageResult struct {
 	URL                string
 	SuccessLinkResults []*successLinkResult
 	ErrorLinkResults   []*errorLinkResult
-	Elapsed            time.Duration
 }
 
 type successLinkResult struct {
 	URL        string
 	StatusCode int
-	Elapsed    time.Duration
 }
 
 type errorLinkResult struct {
-	URL     string
-	Error   error
-	Elapsed time.Duration
+	URL   string
+	Error error
 }
 
 func (r *pageResult) OK() bool {

page_result_formatter_test.go

@@ -10,7 +10,7 @@ import (
 func TestPageResultFormatterFormatEmptyResult(t *testing.T) {
 	cupaloy.SnapshotT(t,
 		newPageResultFormatter(false, true).Format(
-			&pageResult{"http://foo.com", nil, nil, 0},
+			&pageResult{"http://foo.com", nil, nil},
 		),
 	)
 }
@@ -21,10 +21,9 @@ func TestPageResultFormatterFormatSuccessLinkResults(t *testing.T) {
 			&pageResult{
 				"http://foo.com",
 				[]*successLinkResult{
-					{"http://foo.com", 200, 0},
+					{"http://foo.com", 200},
 				},
 				nil,
-				0,
 			},
 		),
 	)
@@ -36,12 +35,11 @@ func TestPageResultFormatterFormatErrorLinkResults(t *testing.T) {
 			&pageResult{
 				"http://foo.com",
 				[]*successLinkResult{
-					{"http://foo.com", 200, 0},
+					{"http://foo.com", 200},
 				},
 				[]*errorLinkResult{
-					{"http://foo.com", errors.New("500"), 0},
+					{"http://foo.com", errors.New("500")},
 				},
-				0,
 			},
 		),
 	)
@@ -53,10 +51,9 @@ func TestPageResultFormatterFormatSuccessLinkResultsVerbosely(t *testing.T) {
 			&pageResult{
 				"http://foo.com",
 				[]*successLinkResult{
-					{"http://foo.com", 200, 0},
+					{"http://foo.com", 200},
 				},
 				nil,
-				0,
 			},
 		),
 	)
@@ -68,12 +65,11 @@ func TestPageResultFormatterFormatErrorLinkResultsVerbosely(t *testing.T) {
 			&pageResult{
 				"http://foo.com",
 				[]*successLinkResult{
-					{"http://foo.com", 200, 0},
+					{"http://foo.com", 200},
 				},
 				[]*errorLinkResult{
-					{"http://foo.com", errors.New("500"), 0},
+					{"http://foo.com", errors.New("500")},
 				},
-				0,
 			},
 		),
 	)
@@ -85,11 +81,10 @@ func TestPageResultFormatterSortSuccessLinkResults(t *testing.T) {
 			&pageResult{
 				"http://foo.com",
 				[]*successLinkResult{
-					{"http://foo.com", 200, 0},
-					{"http://bar.com", 200, 0},
+					{"http://foo.com", 200},
+					{"http://bar.com", 200},
 				},
 				nil,
-				0,
 			},
 		),
 	)
@@ -102,10 +97,9 @@ func TestPageResultFormatterSortErrorLinkResults(t *testing.T) {
 				"http://foo.com",
 				nil,
 				[]*errorLinkResult{
-					{"http://foo.com", errors.New("500"), 0},
-					{"http://bar.com", errors.New("500"), 0},
+					{"http://foo.com", errors.New("500")},
+					{"http://bar.com", errors.New("500")},
 				},
-				0,
 			},
 		),
 	)

page_result_test.go

@@ -7,6 +7,6 @@ import (
 )
 
 func TestPageResultOK(t *testing.T) {
-	assert.True(t, (&pageResult{"", nil, nil, 0}).OK())
-	assert.False(t, (&pageResult{"", nil, []*errorLinkResult{{}}, 0}).OK())
+	assert.True(t, (&pageResult{"", nil, nil}).OK())
+	assert.False(t, (&pageResult{"", nil, []*errorLinkResult{{}}}).OK())
 }

xml_page_result.go

@@ -1,18 +1,16 @@
 package main
 
 type xmlPageResult struct {
-	Url      string  `xml:"name,attr"`
-	Total    int     `xml:"tests,attr"`
-	Failures int     `xml:"failures,attr"`
-	Skipped  int     `xml:"skipped,attr"`
-	Time     float64 `xml:"time,attr"`
+	Url      string `xml:"name,attr"`
+	Total    int    `xml:"tests,attr"`
+	Failures int    `xml:"failures,attr"`
+	Skipped  int    `xml:"skipped,attr"`
 	// spell-checker: disable-next-line
 	Links []*xmlLinkResult `xml:"testcase"`
 }
 
 type xmlLinkResult struct {
-	Url  string  `xml:"name,attr"`
-	Time float64 `xml:"time,attr"`
+	Url string `xml:"name,attr"`
 	// spell-checker: disable-next-line
 	Source  string          `xml:"classname,attr"`
 	Failure *xmlLinkFailure `xml:"failure"`
@@ -31,7 +29,6 @@ func newXMLPageResult(pr *pageResult) *xmlPageResult {
 			&xmlLinkResult{
 				Url:    r.URL,
 				Source: pr.URL,
-				Time:   r.Elapsed.Seconds(),
 			},
 		)
 	}
@@ -42,15 +39,13 @@ func newXMLPageResult(pr *pageResult) *xmlPageResult {
 			&xmlLinkResult{
 				Url:     r.URL,
 				Source:  pr.URL,
-				Time:    r.Elapsed.Seconds(),
 				Failure: &xmlLinkFailure{Message: r.Error.Error()},
 			},
 		)
 	}
 
 	return &xmlPageResult{
-		Url:  pr.URL,
-		Time: pr.Elapsed.Seconds(),
+		Url: pr.URL,
 		// TODO: Consider adding information skipped links, if that can be tracked.
 		Skipped:  0,
 		Total:    len(ls),