bundle.bbclass: support manifest generation for artifacts #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful only in combination with the upcoming support for artifacts, but shouldn't hurt the standard case for now. Signed-off-by: Jan Luebbe <[email protected]>
ejoerns
reviewed
Aug 26, 2024
| # RAUC_BUNDLE_SLOTS += "containers/test" | ||
| # RAUC_SLOT_containers/test ?= "container-test-image" | ||
| # RAUC_SLOT_containers/test[fstype] = "tar.gz" | ||
| # RAUC_SLOT_containers/test[convert] = "extract;composefs" |
There was a problem hiding this comment.
Maybe list existing features here first of all (i.e. tar-extract)
| @@ -291,6 +297,8 @@ def write_manifest(d): | |||
| manifest.write("hooks=%s\n" % slotflags.get('hooks')) | |||
| if 'adaptive' in slotflags: | |||
| manifest.write("adaptive=%s\n" % slotflags.get('adaptive')) | |||
| if 'convert' in slotflags: | |||
| manifest.write("convert=%s\n" % slotflags.get('convert')) | |||
There was a problem hiding this comment.
Doesn't this require to run do_bundle as fakeroot task, too?
There was a problem hiding this comment.
Probably, but that needs some more testing. This can't break existing use-cases though.
| @@ -40,6 +40,12 @@ | |||
| # RAUC_SLOT_rootfs ?= "core-image-minimal" | |||
| # RAUC_SLOT_rootfs[rename] ?= "rootfs.ext4" | |||
| # | |||
| # To generate an artifact image, use <repo>/<artifact> as the image name: | |||
There was a problem hiding this comment.
I'm not quite happy with the syntax and the usage of 'SLOT' for artifacts, but might be the easiest solution first.
There was a problem hiding this comment.
SLOT is wrong here anyway (it should be IMAGE), but changing that in a backwards compatible way will be tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful only in combination with the upcoming support for artifacts, but shouldn't hurt the standard case for now.