-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updatedENthesaurus.yml #4
base: master
Are you sure you want to change the base?
Conversation
Fixed typos from my previous pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I marked a couple of strings that should start with a lowercase letter, but now it got me thinking — maybe all ability descriptions should start with capital letters instead? What do you think?
ru: "обращает врага в камень на 4 хода" | ||
--- | ||
key: ability-dragon-enthrallment | ||
en: "Enthrallment" | ||
ru: "Завораживание" | ||
--- | ||
key: ability-dragon-enthrallment-desc | ||
en: "turns one enemy in {radius} cells radius to ally for {turns} turns" | ||
en: "Enthrall an enemy up to {radius} spaces away, turning it into an ally for {turns} turns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should start with a lowercase letter
ru: "даёт защиту от атак силой {level} на {turns} хода" | ||
--- | ||
key: ability-enthrallment | ||
en: "Enthrallment" | ||
ru: "Завораживание" | ||
--- | ||
key: ability-enthrallment-desc | ||
en: "turns one enemy in {radius} cells radius to ally for {turns} turns" | ||
en: "Enthrall an enemy up to {radius} spaces away, turning it into an ally for {turns} turns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with a lowercase letter
ru: "Посох телепортации" | ||
--- | ||
key: ability-staff-of-teleportation-desc | ||
en: "teleports any die in {radius} cells radius to any cell in {teleport-radius} cells radius" | ||
en: "Teleport any die in range {radius} to a new space up to {teleport-radius} spaces away" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should start with a lowercase letter
ru: "Нестабильного зелья телепортации" | ||
--- | ||
key: ability-potion-of-unstable-teleportation-desc | ||
en: "When drunk or thrown it teleports die to random place in {radius} cells radius" | ||
en: "Teleports the target to a random free space up to {radius} spaces away when drunken or thrown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with a lowercase letter
ru: "Нестабильного зелья удачи" | ||
--- | ||
key: ability-potion-of-unstable-luck-desc | ||
en: "When drunk or thrown it makes a die to either repeat or skip his turn" | ||
en: "Causes the target to either repeat or skip its turn when drunken or thrown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with a lowercase letter
ru: "Бубен забвения" | ||
--- | ||
key: ability-tambourine-of-oblivion-desc | ||
en: "prohibits the enemy in {radius} cells radius to use class abilities for {turns} turns" | ||
en: "Disables the class skills of an enemy up to {radius} spaces away for {turns} turns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with a lowercase letter
By the way, you don't have to create new PRs, you can just add more commits to this one |
Yeah, I agree having all the ability descriptions start with an uppercase letter is more aesthetically pleasing. I'm kind of new to Github, so I wasn't sure how it worked. I tried searching for an option to commit again, but couldn't seem to find it. Will you be updating the Google Play app with the updated strings? |
Hmm, I don't know how to create more commits using github UI, I usually do it using git and then push it. I will release a new version, sure! I'm too busy with other stuff until 17th of April, but after that I'll find some time to figure out how I released it before :) |
Fixed typos from my previous pull