Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enforce validation on notation signature blob number #1726

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Aug 19, 2024

Description

What this PR does / why we need it:

  1. A quick fix to enforce validation on the Notation signature blob number. There should be exactly 1 blob in the manifest.Blobs which is also validated in Notation-go: https://github.com/notaryproject/notation-go/blob/8e2131d192fdb71c5268f81b4b9b93069559d3b5/registry/repository.go#L198
  2. Remove critical cache failure in oras GetReferenceManifest

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Files Patch % Lines
pkg/referrerstore/oras/oras.go 85.71% 1 Missing ⚠️
Files Coverage Δ
pkg/referrerstore/oras/mocks/oras_storage.go 93.33% <100.00%> (+2.42%) ⬆️
pkg/verifier/notation/notation.go 91.39% <100.00%> (+3.27%) ⬆️
pkg/referrerstore/oras/oras.go 71.66% <85.71%> (+3.88%) ⬆️

... and 11 files with indirect coverage changes

@binbin-li binbin-li force-pushed the fix-notation branch 3 times, most recently from 2ce26b7 to 2cb0099 Compare August 19, 2024 15:44
@binbin-li binbin-li changed the title fix: Enforce validation on notation signature blob number []fix: Enforce validation on notation signature blob number Aug 20, 2024
@binbin-li binbin-li changed the title []fix: Enforce validation on notation signature blob number fix: Enforce validation on notation signature blob number Aug 20, 2024
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for double checking spec again

@binbin-li binbin-li enabled auto-merge (squash) August 22, 2024 00:08
@binbin-li binbin-li merged commit 9afbbf9 into ratify-project:dev Aug 22, 2024
19 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li added a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants