-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate plugin version for ratify cli #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
susanshi
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp and
toddysm
as code owners
July 4, 2024 06:09
Signed-off-by: Susan Shi <[email protected]>
binbin-li
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the fix!
akashsinghal
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
akashsinghal
pushed a commit
to akashsinghal/ratify
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Susan Shi <[email protected]> Signed-off-by: akashsinghal <[email protected]>
binbin-li
pushed a commit
to binbin-li/ratify
that referenced
this pull request
Sep 14, 2024
Signed-off-by: Susan Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
validate the plugin version in verifier config against supported versions defined by plugins
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1199
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Test results with incompatible version.
Checklist:
Post Merge Requirements
Helm Chart Change