Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sbom verifier improvements #1205

Merged
merged 10 commits into from
Dec 12, 2023

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Dec 8, 2023

Description

  • adding a e2e test for SBOM verifier
  • update error handling logic to return err in a verifier report, returning the err in the report is a better user experience.
  • updated license check to match on whole word

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f44d451) 55.13% compared to head (b4048f0) 55.13%.

Files Patch % Lines
plugins/verifier/sbom/sbom.go 63.63% 4 Missing ⚠️
plugins/verifier/sbom/utils/spdxutils.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   55.13%   55.13%           
=======================================
  Files         104      104           
  Lines        6865     6879   +14     
=======================================
+ Hits         3785     3793    +8     
- Misses       2749     2753    +4     
- Partials      331      333    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi changed the title feat: add sbom e2e eny feat: add sbom e2e deny Dec 8, 2023
@susanshi susanshi changed the title feat: add sbom e2e deny feat: sbom verifier improvements Dec 8, 2023
@susanshi susanshi marked this pull request as ready for review December 8, 2023 07:54
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akashsinghal akashsinghal merged commit 81291d6 into ratify-project:main Dec 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants