-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add chart icon #1161
chore: add chart icon #1161
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 52.39% 52.39%
=======================================
Files 101 101
Lines 6344 6344
=======================================
Hits 3324 3324
Misses 2699 2699
Partials 321 321 ☔ View full report in Codecov by Sentry. |
591d541
to
61c07fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Is it possible to link to the ratify.dev homepage?
Actually there is a link to ratify.dev: https://ratify.dev/img/ratify-logo.svg, but the logo seems much smaller than the one from Ratify repo. Since they're both svg, I guess we're OK with the smaller one? @akashsinghal |
@binbin-li Oh actually I was referring to a link to ratify.dev as the |
Description
What this PR does / why we need it:
Add icon to helm chart so that it could be displayed on ArtifactHub.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change