Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add chart icon #1161

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

binbin-li
Copy link
Collaborator

Description

What this PR does / why we need it:

Add icon to helm chart so that it could be displayed on ArtifactHub.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52c2c00) 52.39% compared to head (61c07fb) 52.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files         101      101           
  Lines        6344     6344           
=======================================
  Hits         3324     3324           
  Misses       2699     2699           
  Partials      321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@junczhu junczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Is it possible to link to the ratify.dev homepage?

@binbin-li
Copy link
Collaborator Author

Thanks for adding this! Is it possible to link to the ratify.dev homepage?

Actually there is a link to ratify.dev: https://ratify.dev/img/ratify-logo.svg, but the logo seems much smaller than the one from Ratify repo. Since they're both svg, I guess we're OK with the smaller one? @akashsinghal

@akashsinghal
Copy link
Collaborator

akashsinghal commented Nov 3, 2023

Thanks for adding this! Is it possible to link to the ratify.dev homepage?

Actually there is a link to ratify.dev: https://ratify.dev/img/ratify-logo.svg, but the logo seems much smaller than the one from Ratify repo. Since they're both svg, I guess we're OK with the smaller one? @akashsinghal

@binbin-li Oh actually I was referring to a link to ratify.dev as the home URL but actually it seems gatekeeper also keeps home url to be github link. I think this is fine as it is. Please ignore my comment :)

@binbin-li binbin-li merged commit 41b24da into ratify-project:main Nov 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants