-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add health Probe #1058
feat: add health Probe #1058
Conversation
Quickstart
Signed-off-by: Susan Shi <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
- Coverage 58.32% 58.31% -0.02%
==========================================
Files 93 93
Lines 5543 5546 +3
==========================================
+ Hits 3233 3234 +1
- Misses 1994 1996 +2
Partials 316 316
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just 2 minor comments
Hi @binbin-li , this is ready for another round of review. The HA test was failing due to something else was already running at 9090, i ve updated the default port to 9099 |
Signed-off-by: Susan Shi <[email protected]>
Description
fixes #977
What this PR does / why we need it:
Tests:
validated default probe port
validated non default port
validated probe events appear in pod events
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Tests:
validated default probe port
validated non default port
validated probe events appear in pod events ( only failure appears in event log)
Checklist:
Post Merge Requirements
Helm Chart Change