Skip to content

Commit

Permalink
test: improve refresher test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
@duffney
duffney committed Aug 13, 2024
1 parent 75c0e26 commit 08d651f
Show file tree
Hide file tree
Showing 4 changed files with 407 additions and 378 deletions.
90 changes: 67 additions & 23 deletions pkg/controllers/clusterresource/keymanagementprovider_controller_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package clusterresource
import (
"context"
"errors"
"reflect"
"testing"

"github.com/ratify-project/ratify/pkg/keymanagementprovider/refresh"
Expand All @@ -28,26 +29,34 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/fake"
)

func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
func TestKeyManagementProviderReconciler_ReconcileWithConfig(t *testing.T) {
tests := []struct {
name string
refresherType string
expectedError bool
name string
refresherType string
createConfigError bool
refreshError bool
expectedError bool
}{
{
name: "Successful Reconcile",
refresherType: "mockRefresher",
expectedError: false,
name: "Successful Reconcile",
refresherType: "mockRefresher",
createConfigError: false,
refreshError: false,
expectedError: false,
},
{
name: "Refresher Error",
refresherType: "mockRefresher",
expectedError: true,
name: "Refresher Error",
refresherType: "mockRefresher",
createConfigError: false,
refreshError: true,
expectedError: true,
},
{
name: "Invalid Refresher Type",
refresherType: "invalidRefresher",
expectedError: true,
name: "Invalid Refresher Type",
refresherType: "invalidRefresher",
createConfigError: true,
refreshError: false,
expectedError: true,
},
}
for _, tt := range tests {
Expand All @@ -67,10 +76,12 @@ func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
}

refresherConfig := map[string]interface{}{
"type": tt.refresherType,
"client": client,
"request": req,
"shouldError": tt.expectedError,
"type": tt.refresherType,
"client": client,
"request": req,
"createConfigError": tt.createConfigError,
"refreshError": tt.refreshError,
"shouldError": tt.expectedError,
}

_, err := r.ReconcileWithConfig(context.TODO(), refresherConfig)
Expand All @@ -83,14 +94,45 @@ func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
})
}
}
func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
req := ctrl.Request{
NamespacedName: client.ObjectKey{
Name: "fake-name",
Namespace: "fake-namespace",
},
}

// Create a fake client and scheme
scheme, _ := test.CreateScheme()
client := fake.NewClientBuilder().WithScheme(scheme).Build()

r := &KeyManagementProviderReconciler{
Client: client,
Scheme: runtime.NewScheme(),
}

// Call the Reconcile method
result, err := r.Reconcile(context.TODO(), req)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}

// Check the result
expectedResult := ctrl.Result{}
if !reflect.DeepEqual(result, expectedResult) {
t.Errorf("Expected result %v, got %v", expectedResult, result)
}
}

type MockRefresher struct {
Results ctrl.Result
ShouldError bool
Results ctrl.Result
CreateConfigError bool
RefreshError bool
ShouldError bool
}

func (mr *MockRefresher) Refresh(_ context.Context) error {
if mr.ShouldError {
if mr.RefreshError {
return errors.New("refresh error")
}
return nil
Expand All @@ -101,12 +143,14 @@ func (mr *MockRefresher) GetResult() interface{} {
}

func (mr *MockRefresher) Create(config map[string]interface{}) (refresh.Refresher, error) {
shouldError := config["shouldError"].(bool)
if shouldError {
createConfigError := config["createConfigError"].(bool)
refreshError := config["refreshError"].(bool)
if createConfigError {
return nil, errors.New("create error")
}
return &MockRefresher{
ShouldError: shouldError,
CreateConfigError: createConfigError,
RefreshError: refreshError,
}, nil
}

Expand Down
91 changes: 68 additions & 23 deletions pkg/controllers/namespaceresource/keymanagementprovider_controller_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package namespaceresource
import (
"context"
"errors"
"reflect"
"testing"

"github.com/ratify-project/ratify/pkg/keymanagementprovider/refresh"
Expand All @@ -28,26 +29,34 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/fake"
)

func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
func TestKeyManagementProviderReconciler_ReconcileWithConfig(t *testing.T) {
tests := []struct {
name string
refresherType string
expectedError bool
name string
refresherType string
createConfigError bool
refreshError bool
expectedError bool
}{
{
name: "Successful Reconcile",
refresherType: "mockRefresher",
expectedError: false,
name: "Successful Reconcile",
refresherType: "mockRefresher",
createConfigError: false,
refreshError: false,
expectedError: false,
},
{
name: "Refresher Error",
refresherType: "mockRefresher",
expectedError: true,
name: "Refresher Error",
refresherType: "mockRefresher",
createConfigError: false,
refreshError: true,
expectedError: true,
},
{
name: "Invalid Refresher Type",
refresherType: "invalidRefresher",
expectedError: true,
name: "Invalid Refresher Type",
refresherType: "invalidRefresher",
createConfigError: true,
refreshError: false,
expectedError: true,
},
}
for _, tt := range tests {
Expand All @@ -67,10 +76,12 @@ func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
}

refresherConfig := map[string]interface{}{
"type": tt.refresherType,
"client": client,
"request": req,
"shouldError": tt.expectedError,
"type": tt.refresherType,
"client": client,
"request": req,
"createConfigError": tt.createConfigError,
"refreshError": tt.refreshError,
"shouldError": tt.expectedError,
}

_, err := r.ReconcileWithConfig(context.TODO(), refresherConfig)
Expand All @@ -84,13 +95,45 @@ func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
}
}

func TestKeyManagementProviderReconciler_Reconcile(t *testing.T) {
req := ctrl.Request{
NamespacedName: client.ObjectKey{
Name: "fake-name",
Namespace: "fake-namespace",
},
}

// Create a fake client and scheme
scheme, _ := test.CreateScheme()
client := fake.NewClientBuilder().WithScheme(scheme).Build()

r := &KeyManagementProviderReconciler{
Client: client,
Scheme: runtime.NewScheme(),
}

// Call the Reconcile method
result, err := r.Reconcile(context.TODO(), req)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}

// Check the result
expectedResult := ctrl.Result{}
if !reflect.DeepEqual(result, expectedResult) {
t.Errorf("Expected result %v, got %v", expectedResult, result)
}
}

type MockRefresher struct {
Results ctrl.Result
ShouldError bool
Results ctrl.Result
CreateConfigError bool
RefreshError bool
ShouldError bool
}

func (mr *MockRefresher) Refresh(_ context.Context) error {
if mr.ShouldError {
if mr.RefreshError {
return errors.New("refresh error")
}
return nil
Expand All @@ -101,12 +144,14 @@ func (mr *MockRefresher) GetResult() interface{} {
}

func (mr *MockRefresher) Create(config map[string]interface{}) (refresh.Refresher, error) {
shouldError := config["shouldError"].(bool)
if shouldError {
createConfigError := config["shouldError"].(bool)
refreshError := config["refreshError"].(bool)
if createConfigError {
return nil, errors.New("create error")
}
return &MockRefresher{
ShouldError: shouldError,
CreateConfigError: createConfigError,
RefreshError: refreshError,
}, nil
}

Expand Down
Loading

0 comments on commit 08d651f

Please sign in to comment.