Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color): fix doc test for from_hsl #1421

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(color): fix doc test for from_hsl #1421

merged 1 commit into from
Oct 15, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Oct 15, 2024

No description provided.

@joshka joshka requested a review from a team as a code owner October 15, 2024 09:59
@joshka joshka mentioned this pull request Oct 15, 2024
Merged
@orhun orhun changed the title fix: from_hsl doc test fix(color): fix doc test for from_hsl Oct 15, 2024
@orhun orhun merged commit b7e4885 into main Oct 15, 2024
35 of 38 checks passed
@orhun orhun deleted the jm/fix-color-doc-test branch October 15, 2024 10:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

🐰 Bencher Report

Branch1421/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
barchart/render/2048📈 view plot
⚠️ NO THRESHOLD		197,360.00
barchart/render/256📈 view plot
⚠️ NO THRESHOLD		129,710.00
barchart/render/64📈 view plot
⚠️ NO THRESHOLD		85,307.00
barchart/render_grouped/2048📈 view plot
⚠️ NO THRESHOLD		339,260.00
barchart/render_grouped/256📈 view plot
⚠️ NO THRESHOLD		140,300.00
barchart/render_grouped/64📈 view plot
⚠️ NO THRESHOLD		128,460.00
barchart/render_horizontal/2048📈 view plot
⚠️ NO THRESHOLD		164,220.00
barchart/render_horizontal/256📈 view plot
⚠️ NO THRESHOLD		83,118.00
barchart/render_horizontal/64📈 view plot
⚠️ NO THRESHOLD		77,858.00
block/render_all_feature/100x50📈 view plot
⚠️ NO THRESHOLD		11,323.00
block/render_all_feature/200x50📈 view plot
⚠️ NO THRESHOLD		20,172.00
block/render_all_feature/256x256📈 view plot
⚠️ NO THRESHOLD		95,222.00
block/render_empty/100x50📈 view plot
⚠️ NO THRESHOLD		6,206.00
block/render_empty/200x50📈 view plot
⚠️ NO THRESHOLD		12,488.00
block/render_empty/256x256📈 view plot
⚠️ NO THRESHOLD		80,276.00
buffer/empty/16📈 view plot
⚠️ NO THRESHOLD		794.30
buffer/empty/255📈 view plot
⚠️ NO THRESHOLD		229,970.00
buffer/empty/64📈 view plot
⚠️ NO THRESHOLD		13,439.00
buffer/filled/16📈 view plot
⚠️ NO THRESHOLD		789.52
buffer/filled/255📈 view plot
⚠️ NO THRESHOLD		219,200.00
buffer/filled/64📈 view plot
⚠️ NO THRESHOLD		13,137.00
buffer/with_lines/16📈 view plot
⚠️ NO THRESHOLD		15,337.00
buffer/with_lines/255📈 view plot
⚠️ NO THRESHOLD		16,024.00
buffer/with_lines/64📈 view plot
⚠️ NO THRESHOLD		13,418.00
line_render/Center/0📈 view plot
⚠️ NO THRESHOLD		3.73
line_render/Center/10📈 view plot
⚠️ NO THRESHOLD		631.72
line_render/Center/3📈 view plot
⚠️ NO THRESHOLD		297.94
line_render/Center/4📈 view plot
⚠️ NO THRESHOLD		340.60
line_render/Center/42📈 view plot
⚠️ NO THRESHOLD		851.38
line_render/Center/6📈 view plot
⚠️ NO THRESHOLD		402.99
line_render/Center/7📈 view plot
⚠️ NO THRESHOLD		456.84
line_render/Left/0📈 view plot
⚠️ NO THRESHOLD		3.73
line_render/Left/10📈 view plot
⚠️ NO THRESHOLD		599.15
line_render/Left/3📈 view plot
⚠️ NO THRESHOLD		231.66
line_render/Left/4📈 view plot
⚠️ NO THRESHOLD		244.61
line_render/Left/42📈 view plot
⚠️ NO THRESHOLD		850.86
line_render/Left/6📈 view plot
⚠️ NO THRESHOLD		390.72
line_render/Left/7📈 view plot
⚠️ NO THRESHOLD		404.86
line_render/Right/0📈 view plot
⚠️ NO THRESHOLD		3.73
line_render/Right/10📈 view plot
⚠️ NO THRESHOLD		568.28
line_render/Right/3📈 view plot
⚠️ NO THRESHOLD		274.27
line_render/Right/4📈 view plot
⚠️ NO THRESHOLD		330.31
line_render/Right/42📈 view plot
⚠️ NO THRESHOLD		850.22
line_render/Right/6📈 view plot
⚠️ NO THRESHOLD		443.24
line_render/Right/7📈 view plot
⚠️ NO THRESHOLD		499.04
list/render/16384📈 view plot
⚠️ NO THRESHOLD		1,200,000.00
list/render/2048📈 view plot
⚠️ NO THRESHOLD		332,460.00
list/render/64📈 view plot
⚠️ NO THRESHOLD		211,640.00
list/render_scroll_half/16384📈 view plot
⚠️ NO THRESHOLD		1,191,000.00
list/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		330,260.00
list/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		144,310.00
paragraph/new/2048📈 view plot
⚠️ NO THRESHOLD		257,570.00
paragraph/new/64📈 view plot
⚠️ NO THRESHOLD		6,871.70
paragraph/new/65535📈 view plot
⚠️ NO THRESHOLD		8,207,700.00
paragraph/render/2048📈 view plot
⚠️ NO THRESHOLD		625,910.00
paragraph/render/64📈 view plot
⚠️ NO THRESHOLD		586,890.00
paragraph/render/65535📈 view plot
⚠️ NO THRESHOLD		1,709,400.00
paragraph/render_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		608,580.00
paragraph/render_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		630,080.00
paragraph/render_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,729,100.00
paragraph/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		608,550.00
paragraph/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		633,400.00
paragraph/render_scroll_half/65535📈 view plot
⚠️ NO THRESHOLD		1,728,900.00
paragraph/render_wrap/2048📈 view plot
⚠️ NO THRESHOLD		305,000.00
paragraph/render_wrap/64📈 view plot
⚠️ NO THRESHOLD		266,450.00
paragraph/render_wrap/65535📈 view plot
⚠️ NO THRESHOLD		1,483,200.00
paragraph/render_wrap_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		305,030.00
paragraph/render_wrap_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		265,200.00
paragraph/render_wrap_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,489,600.00
rect_rows/rows/1024📈 view plot
⚠️ NO THRESHOLD		324.32
rect_rows/rows/16📈 view plot
⚠️ NO THRESHOLD		5.60
rect_rows/rows/65535📈 view plot
⚠️ NO THRESHOLD		20,396.00
sparkline/render/2048📈 view plot
⚠️ NO THRESHOLD		116,080.00
sparkline/render/256📈 view plot
⚠️ NO THRESHOLD		111,180.00
sparkline/render/64📈 view plot
⚠️ NO THRESHOLD		35,843.00
table/render/16384x2📈 view plot
⚠️ NO THRESHOLD		2,893,200.00
table/render/16384x4📈 view plot
⚠️ NO THRESHOLD		5,518,600.00
table/render/16384x8📈 view plot
⚠️ NO THRESHOLD		21,868,000.00
table/render/2048x2📈 view plot
⚠️ NO THRESHOLD		663,060.00
table/render/2048x4📈 view plot
⚠️ NO THRESHOLD		1,116,600.00
table/render/2048x8📈 view plot
⚠️ NO THRESHOLD		1,828,300.00
table/render/64x2📈 view plot
⚠️ NO THRESHOLD		343,200.00
table/render/64x4📈 view plot
⚠️ NO THRESHOLD		536,740.00
table/render/64x8📈 view plot
⚠️ NO THRESHOLD		629,470.00
table/render_scroll_half/16384x2📈 view plot
⚠️ NO THRESHOLD		2,866,800.00
table/render_scroll_half/16384x4📈 view plot
⚠️ NO THRESHOLD		5,889,100.00
table/render_scroll_half/16384x8📈 view plot
⚠️ NO THRESHOLD		20,748,000.00
table/render_scroll_half/2048x2📈 view plot
⚠️ NO THRESHOLD		666,220.00
table/render_scroll_half/2048x4📈 view plot
⚠️ NO THRESHOLD		1,120,100.00
table/render_scroll_half/2048x8📈 view plot
⚠️ NO THRESHOLD		1,818,200.00
table/render_scroll_half/64x2📈 view plot
⚠️ NO THRESHOLD		229,180.00
table/render_scroll_half/64x4📈 view plot
⚠️ NO THRESHOLD		349,930.00
table/render_scroll_half/64x8📈 view plot
⚠️ NO THRESHOLD		409,940.00
🐰 View full continuous benchmarking report in Bencher

kdheepak added a commit that referenced this pull request Oct 16, 2024
@kdheepak
Merge remote-tracking branch 'origin/main' into kd/overlap
afbb2dd 
* origin/main: (21 commits)
  perf: implement size hints for `Rect` iterators (#1420)
  fix(color): fix doc test for from_hsl (#1421)
  docs: tweak readme (#1419)
  refactor(color)!: use palette types for Hsl/Hsluv conversions (#1418)
  chore(deps)!: pin unicode-width to 0.2.0 (#1403)
  feat(scrolling-regions)!: use terminal scrolling regions to stop Terminal::insert_before from flickering (#1341)
  feat!: add an impl of `DoubleEndedIterator` for `Columns` and `Rows` (#1358)
  fix(rect)!: Rect::area now returns u32 and Rect::new() no longer clamps area to u16::MAX (#1378)
  docs: fix missing breaking changes link (#1416)
  feat(line)!: impl From<Cow<str>> for Line (#1373)
  chore(deny): allow Zlib license in cargo-deny configuration (#1411)
  feat(tabs)!: allow tabs to be deselected (#1413)
  feat(color): add hsluv support (#1333)
  feat(table)!: add support for selecting column and cell (#1331)
  feat(text): improve concise debug view for Span,Line,Text,Style (#1410)
  chore: add benchmark for `Table` (#1408)
  refactor: Consistent result expected in layout tests (#1406)
  feat(logo): Add a Ratatui logo widget
  chore(deps): update rstest requirement from 0.22.0 to 0.23.0 (#1394)
  chore(deps): update octocrab requirement from 0.40.0 to 0.41.0 (#1393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun