Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set global RAT-PAC2 compile flag to -Wall -Werror #200

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Set global RAT-PAC2 compile flag to -Wall -Werror #200

wants to merge 5 commits into from

Conversation

JamesJieranShen
Copy link
Contributor

... and also corresponding code changes that address the compile errors. Nothing should be substantial. Most errors are:

  • size_t vs int sign issues
  • unused variables
  • c string comparisons

tannerbk
tannerbk reviewed Nov 7, 2024
View reviewed changes
src/gen/src/GLG4PosGen.cc Outdated Show resolved Hide resolved
src/gen/src/VertexGen_CRY.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannerbk tannerbk tannerbk left review comments

Assignees
No one assigned
Labels
Structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesJieranShen @tannerbk