Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh package-lock.json #130

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Refresh package-lock.json #130

merged 1 commit into from
Jan 31, 2019

Conversation

lederer
Copy link
Contributor

@lederer lederer commented Jan 30, 2019

Overview

Fix the broken build:

  • Bump docz
  • Install docz-theme-default (now required by docz)
  • Hold webpack at 4.28.4
  • Delete all package-lock.json's throughout project
  • Reinstall all npm packages

According to doczjs/docz#596, once docz 0.14 is released, we can stop holding webpack at 4.28.4.

As part of investigating this, I also:

  • normalized the version of styled-components throughout the repo
  • upgraded lerna from v2 to v3

Those turned out to not be necessary, but they also didn't break anything, so figured I'd leave them in.

Checklist

  • Relevant documentation pages have been created or updated
  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Are there any of the following in this PR?

  • Changes to the prop names or types of existing components
  • Changes in intended behavior of existing component props
  • Changes in the theme file's structure
  • A required version bump to a non-dev dependency of the project

If one of the above is checked...

  • information or guidance around needed changes for consumers of this library has been added to the changelog under Upgrade Instructions

Demo

image

Testing Instructions

  • npm run clean && npm i && npm run start
  • Confirm docz runs as expected

@lederer
Copy link
Contributor Author

lederer commented Jan 30, 2019

@alkamin Hold off on reviewing this until I figure out the deployment issues.

- Hold webpack at 4.28.4
- Bump docz
- Bump styled-components in packages/*
- Bump lerna
- Refresh all package-lock.json's
@lederer lederer force-pushed the fix/sml/package-lock.json branch from 3384a20 to 389ec11 Compare January 31, 2019 14:12
@lederer
Copy link
Contributor Author

lederer commented Jan 31, 2019

Ready for another look. CI and deployment checks all passed. I updated the original comment to reflect the updated solution.

Note the bit about holding webpack at 4.28.4 until docz 0.14 is released. I'll keep my eye on that.

@lederer lederer merged commit d196c32 into master Jan 31, 2019
@lederer lederer deleted the fix/sml/package-lock.json branch January 31, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants