Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GPS version to 23 #594

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Update the GPS version to 23 #594

merged 1 commit into from
Nov 14, 2019

Conversation

JamesH65
Copy link
Collaborator

Buster now has gpsd version 23, (up from 22)

This PR updates the camera code to reflect the change.

Buster now has gpsd version 23, (up from 22)

This PR updates the camera code to reflect the change.
@JamesH65 JamesH65 requested review from 6by9 and pelwell November 14, 2019 11:08
@JamesH65
Copy link
Collaborator Author

Note, the change to gps.h is simply a copy of the v23 version over the top of the v22 version.

@6by9
Copy link
Contributor

6by9 commented Nov 14, 2019

Do we want to just do this simplistic bump the version? It'll now be broken on Stretch.

I haven't looked at what symlinks or automagic mangling of the library name happens in dlopen, but it'd be nice to be able to load a generic library filename and then check against supported versions. Don't know if that is actually possible though.

@JamesH65
Copy link
Collaborator Author

Do we want to just do this simplistic bump the version? It'll now be broken on Stretch.

I haven't looked at what symlinks or automagic mangling of the library name happens in dlopen, but it'd be nice to be able to load a generic library filename and then check against supported versions. Don't know if that is actually possible though.

I did wonder about that, but on the whole we only have support for the current version of the distro, ie backward rather than forward compatibility. Might be worth asking @XECDesign though.

@XECDesign
Copy link
Contributor

Stretch is unlikely to get libraspberrypi0 updates. If you would like to provide an option for people to build it themselves, you could use ifdefs or dynamically load the appropriate .so at runtime and deal with whatever API differences might be relevant.

Personally, I'm in the "we don't support old releases" camp.

@6by9
Copy link
Contributor

6by9 commented Nov 14, 2019

Fine, ditch libgps.22

@popcornmix popcornmix merged commit 3e0bbcf into master Nov 14, 2019
@popcornmix popcornmix deleted the cam_update_gpsd_23 branch November 14, 2019 15:21
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Nov 18, 2019
kernel: v3d_drv: Use firmware mailbox call for clock requests
See: raspberrypi/linux#3140

kernel: arm: dts: overlays: pitft35-resistive: add upstream compatible
See: raspberrypi/linux#3338

firmware: Reduce voltage as part of DVFS

firmware: arm-loader: Inherit 2711 mac-address from the bootloader
See: http://git/vc4/vc4/merge_requests/687

userland: uservcsm: Fix incorrect struct type
See: raspberrypi/userland#596

userland: Update the GPS version to 23
See: raspberrypi/userland#594
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Nov 18, 2019
kernel: v3d_drv: Use firmware mailbox call for clock requests
See: raspberrypi/linux#3140

kernel: arm: dts: overlays: pitft35-resistive: add upstream compatible
See: raspberrypi/linux#3338

firmware: Reduce voltage as part of DVFS

firmware: arm-loader: Inherit 2711 mac-address from the bootloader
See: http://git/vc4/vc4/merge_requests/687

userland: uservcsm: Fix incorrect struct type
See: raspberrypi/userland#596

userland: Update the GPS version to 23
See: raspberrypi/userland#594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants