Update motion_detect_stage.cpp to allow specification of optional region name for output logging. #758
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion name for output logging.
|
The change seems reasonable and I am happy to merge this. Would you be able to update the commit message to something like this before I do so: |
|
@naushir I got a style error on the PR build, which I fixed in a second commit. Are you able to "squash and merge" and change the commit title/message to what you suggested? |
|
Sure, but can you provide your name/email for the sign-off tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and confirmed that it is backwards compatible with json config that does not have region_name specified.
This change allows multiple motion_detect post-processing stages to be differentiated from one another in their "motion detected" and "motion stopped" log messages.