Add VID and PID device target filters #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-pecserke
force-pushed
the
feature/vid-pid-device-target-filters
branch
from
ec92534
to
4313928
Compare
|
This should probably be targeting the |
tomas-pecserke
force-pushed
the
feature/vid-pid-device-target-filters
branch
from
4313928
to
96bdf4c
Compare
tomas-pecserke
force-pushed
the
feature/vid-pid-device-target-filters
branch
from
96bdf4c
to
0cd1357
Compare
|
These have been added for picotool 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves usability of #83 and depends on #84.
It adds
--vid <vid>and--pid <pid>device target filter options to device selection accepting hex id representation.The Vendor ID and Product ID is then compared with identifiers specified by
idVendorandidProductof device configuration option respectively.This solution does NOT break backward compatibility - functionality and outputs do not change if the flag is not specified.
Usage:
# TinyUSB examples use Cafe:0200 picotool info --pid cafe --vid 0200❗Attention: Help needed with clipp options for these filters.
Currently I have all the options as optional and despite that i get this error when used without any options:
$ picotool info ERROR: missing required argument SYNOPSIS: picotool info [-b] [-p] [-d] [-l] [-a] [--bus <bus>] [--address <addr>] [--vid <vid>] [--pid <pid>] [--serial <serial>] [-f] [-F] picotool info [-b] [-p] [-d] [-l] [-a] <filename> [-t <type>] Use "picotool help info" for more infoIf you have any idea why, please let me know.