Add JSON schemas #176
Merged
Add JSON schemas #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
|
Should one of these schema files contain all the info from section 13.9 of the RP2350 datasheet, or is this the wrong place for that? |
I think this is the wrong place for that - that section of the datasheet is probably the best place for that information, as |
Fix sample-...json file references in readme Use `$defs` for pt permissions Fix typos
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
lurch
reviewed
Nov 15, 2024
Both must be specified in the JSON file, as they get written together
Only 4 values are actually allowed
lurch
reviewed
Nov 15, 2024
| "description": "Value to write", | ||
| "type": ["array", "string", "integer"], | ||
| "pattern": "^0x[0-9a-fA-F]{1,6}$", | ||
| "items": { |
There was a problem hiding this comment.
I guess items here could also be a $ref, but I'll let you decide if it's worth it or not.
kilograham
approved these changes
Nov 19, 2024
|
@will-v-pi Don't forget to update the schema URLs before hitting the big green Merge button 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JSON schemas for the JSON inputs used.
Currently the URLs point to the jsonschema branch - these should be changed to the develop branch once merged.
Fixes #172