Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pico_aon_timer pulls in a lot of C Lib code on RP2040 #1810

Closed
kilograham opened this issue Aug 12, 2024 · 4 comments
Closed

pico_aon_timer pulls in a lot of C Lib code on RP2040 #1810

kilograham opened this issue Aug 12, 2024 · 4 comments
Assignees
@kilograham
Milestone
2.1.0

Comments

@kilograham
Copy link
Contributor

See micropython/micropython#15619
@kilograham kilograham added this to the 2.0.1 milestone Aug 12, 2024
@kilograham kilograham self-assigned this Aug 12, 2024
@kilograham
Copy link
Contributor Author

We should offer both time and date based libraries perhaps, and/or at least let people plug in their own conversion routines if they already have them

projectgus added a commit to projectgus/micropython that referenced this issue Aug 13, 2024
@projectgus
rp2: Woarkaround pico_aon_timer timezone binary size increase.
94edc4f 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
projectgus added a commit to projectgus/micropython that referenced this issue Aug 13, 2024
@projectgus
rp2: Workaround pico_aon_timer timezone binary size increase.
debc0ad 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Aug 30, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
89b17d1 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Sep 2, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
fcd7c50 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Sep 5, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
c471464 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Sep 26, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
bf81438 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
peterharperuk pushed a commit to peterharperuk/micropython that referenced this issue Oct 10, 2024
@projectgus @peterharperuk
rp2: Workaround pico_aon_timer timezone binary size increase.
3240949 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Oct 11, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
e9394b6 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Oct 11, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
1ad690f 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
dpgeorge pushed a commit to dpgeorge/micropython that referenced this issue Oct 15, 2024
@projectgus @dpgeorge
rp2: Workaround pico_aon_timer timezone binary size increase.
8cc7c64 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
@kilograham kilograham modified the milestones: 2.1.0, 2.2.0 Nov 20, 2024
@kilograham
Copy link
Contributor Author

Since this is worked-around in MP i'm gonna push this to 2.2.0 as I don't have a magic bullet for the general case

@kilograham kilograham modified the milestones: 2.2.0, 2.1.0 Nov 21, 2024
@kilograham
Copy link
Contributor Author

actually changed my mind again

@kilograham kilograham mentioned this issue Nov 21, 2024
Merged
@kilograham
Copy link
Contributor Author

merged into develop

PepperoniPingu pushed a commit to PepperoniPingu/micropython-nix that referenced this issue Jan 6, 2025
@projectgus @PepperoniPingu
rp2: Workaround pico_aon_timer timezone binary size increase.
442260e 
Provide stub implementations of localtime_r() and mktime() to avoid
code size increase.

Reported upstream at raspberrypi/pico-sdk#1810

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilograham kilograham

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@kilograham