Add an example to read VBUS and VSYS #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Feb 14, 2023
lurch
reviewed
Feb 14, 2023
|
Hmmm, just occurred to me that maybe this example should be using the binary_info stuff too? |
peterharperuk
force-pushed
the
add_vbus_vsys_example
branch
from
c12333f
to
2d3cb99
Compare
lurch
reviewed
Feb 14, 2023
lurch
reviewed
Feb 14, 2023
The process is different on Pico and Pico W so demonstrate how to do it. Fixes raspberrypi#324
peterharperuk
force-pushed
the
add_vbus_vsys_example
branch
from
2d3cb99
to
d534ada
Compare
|
LGTM (although I've not actually tried testing it). |
cyw43 needs to be on to read vbus. Low values are read when cyw43 goes to sleep (or wakes up?)
kilograham
previously approved these changes
Jun 6, 2023
kilograham
approved these changes
Jun 6, 2023
oddstr13
reviewed
Aug 22, 2023
| #if CYW43_USES_VSYS_PIN | ||
| cyw43_thread_enter(); | ||
| // Make sure cyw43 is awake | ||
| cyw43_arch_gpio_get(CYW43_WL_GPIO_VBUS_PIN); |
There was a problem hiding this comment.
cyw43_arch_gpio_get communicates with the wifi chip, and also calls to cyw43_thread_enter and cyw43_thread_exit.
Would that not cause conflicts and or release our lock too soon?
There was a problem hiding this comment.
Are you seeing an issue? You can nest calls to enter and exit so I wouldn't expect this to be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process is different on Pico and Pico W so demonstrate how to do it.
Fixes #324