HID: usbhid: Insert USB bus/device ID into HID name #6356
Conversation
|
|
||
| if (dev->product) { | ||
| if (dev->manufacturer) | ||
| strlcat(hid->name, " ", sizeof(hid->name)); | ||
| strlcat(hid->name, dev->product, sizeof(hid->name)); | ||
| } | ||
|
|
||
| if (!strlen(hid->name)) | ||
| snprintf(hid->name, sizeof(hid->name), "HID %04x:%04x", | ||
| if (strlen(hid->name) == strlen(dev_name(&dev->dev))) |
There was a problem hiding this comment.
Given the snprintf above, and the fact that other changes just append, how can this condition ever be true?
There was a problem hiding this comment.
It can't.
Too many revisions switching from strscpy to snprintf (to add the usb- prefix), and missing updating this condition.
Ideally this issue wants to be sorted further up the stack (xinput was always happy with multiple identical devices, although you had to reference them by id number rather than name), so I'll have a word with Simon and David T later on.
|
I have tested this patch, but I guess it introduced regression I have installed wayfire 0.9.0 using wf-install https://github.com/WayfireWM/wf-install Below the complete logs `
|
|
You've also changed the version of Wayfire too. That's more likely to have caused your problem (undefined symbol: _ZNK2wf18activatorbinding_t14get_extensionsB5cxx11Ev) than the kernel change. |
|
I will test again with the default Wayfire 0.7.5 |
|
running the default Wayfire 0.7.5 and I get
|
libinput/wlroots/Wayfire/labwc match input device by the device name only. If you add 2 identical USB connected touch devices, you can't select between them. Add the usb bus&device name to the start of the name so that the names end up being unique, Signed-off-by: Dave Stevenson <[email protected]>
6by9
force-pushed
the
rpi-6.6.y-usbhid
branch
from
bf30f12
to
aeebabd
Compare
|
Start with a clean install of Raspberry Pi OS. This branch is now nearly 3 months out of date as it had no feedback. I have now rebased the branch so CI will rebuild it, but I'd be surprised if it changed much. |
Thanks! I will install a new Raspberry Pi OS than apply this patch and ping you again |
|
I have started with a clean install of Raspberry Pi OS and than pulled the patch and rebooted. 1- I have tried the setup through the GUI 
and then set up the walyland Env This has worked perfectly! Both touchscreens are working as expected. 2- I wanted to run wayfire through cli
However, the patch that you have introduced have solved the issue. Thanks a lot |
Draft as this isn't ideal - it renames all mouse and keyboard devices, as well as touch ones.
libinput/wlroots/Wayfire/labwc match input device by the device name only. If you add 2 identical USB connected touch devices, you can't select between them.
Add the usb bus&device name to the start of the name so that the names end up being unique,
https://forums.raspberrypi.com/viewtopic.php?t=376569