media: rp1: csi2: Fix set_fmt for the source #6169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver allows changing the source pad's format to the 16-bit or the compressed version, but doesn't allow changing it back to the sink's format. A work-around for the user is to set the format to the sink side, which then gets propagated correctly. Fix the driver to allow changing the source format back to the sink's format. Signed-off-by: Tomi Valkeinen <[email protected]>
|
@naushir jfyi |
|
Hmm, I think we have the same issue in the FE. I'll refresh the series. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver allows changing the source pad's format to the 16-bit or the compressed version, but doesn't allow changing it back to the sink's format. A work-around for the user is to set the format to the sink side, which then gets propagated correctly.
Fix the driver to allow changing the source format back to the sink's format.