Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB order override for DPI #6156

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented May 10, 2024

Quick (untested) mod for #6155

It's either this or adding a load of extra MEDIA_BUS_FMTs.

@njhollinghurst
Copy link
Contributor

Will we be wanting this on RP1 as well? (BTW the latter can also generate several other pinouts that would leave a gap for I2S, but I expect VC4 can't match those. I mention it in case it helps forward planning...)

@6by9
Copy link
Contributor Author

6by9 commented May 10, 2024

Will we be wanting this on RP1 as well? (BTW the latter can also generate several other pinouts that would leave a gap for I2S, but I expect VC4 can't match those. I mention it in case it helps forward planning...)

Yes we'll probably want something similar on RP1.
The dpi DT node should be remapped to the RP1 peripheral on Pi5 so the property would exist with the overlay change, but the driver would obviously need to look for it. Handling the values in a generic manner might want a little more thought.

@6by9 6by9 force-pushed the rpi-6.6.y-dpi branch 2 times, most recently from 13ceec3 to 1d54d5e Compare May 14, 2024 14:05
@6by9
Copy link
Contributor Author

6by9 commented May 14, 2024

Updated and now takes a string for the RGB order so that all orders can be handled in the RP1 driver.

I think this handles the use case fairly cleanly, so dropping the draft status.
(I know I should have updated the DT bindings too, but I doubt this will ever be acceptable to upstream anyway)

@6by9 6by9 marked this pull request as ready for review May 14, 2024 14:08
6by9 added 2 commits May 17, 2024 18:18
There are no MEDIA_BUS_FMT_* defines for GRB or BRG, and adding
them is a pain.

Add a DT override to allow setting the order.

Signed-off-by: Dave Stevenson <[email protected]>
Sets the new DT property for rgb-order.

Signed-off-by: Dave Stevenson <[email protected]>
@pelwell pelwell merged commit 0c14736 into raspberrypi:rpi-6.6.y May 17, 2024
12 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request May 20, 2024
kernel: RGB order override for DPI
See: raspberrypi/linux#6156

kernel: Minor panel fixups
See: raspberrypi/linux#6176

kernel: dtoverlays: Fix noints mode of mcp23017
See: raspberrypi/linux#6174

kernel: DTS: bcm2712: set nonzero QoS values for PCIE1
See: raspberrypi/linux#6171

kernel: staging: bcm2835_codec: Pass framerate to the component if set late
See: raspberrypi/linux#6108

kernel: spi: dw: Handle any number of gpiod CS lines
See: raspberrypi/linux#6161
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request May 20, 2024
kernel: RGB order override for DPI
See: raspberrypi/linux#6156

kernel: Minor panel fixups
See: raspberrypi/linux#6176

kernel: dtoverlays: Fix noints mode of mcp23017
See: raspberrypi/linux#6174

kernel: DTS: bcm2712: set nonzero QoS values for PCIE1
See: raspberrypi/linux#6171

kernel: staging: bcm2835_codec: Pass framerate to the component if set late
See: raspberrypi/linux#6108

kernel: spi: dw: Handle any number of gpiod CS lines
See: raspberrypi/linux#6161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants