vc04_services: bcm2835-codec: Correct alignment requirements for YUYV #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firmware wants the YUYV format stride alignment to be to a multiple of 32pixels / 64 bytes. The kernel driver was configuring it to a multiple of 16 pixels / 32 bytes, which then failed when it tried starting to stream. Correct the alignment requirements. Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 12, 2023
kernel: configs: Enable more sound devices See: raspberrypi/linux#5637 kernel: media: i2c: ov9282: Read chip ID via 2 reads See: raspberrypi/linux#5644 kernel: vc04_services: bcm2835-codec: Correct alignment requirements for YUYV See: raspberrypi/linux#5646 kernel: xhci: add quirk for host controllers that don't update endpoint DCS See: raspberrypi/linux#5642 kernel: drivers: media: rp1_cfe: Remove PISP specific MBUS formats See: raspberrypi/linux#5641 kernel: media/rpivid: Make iommu work on rpivid See: raspberrypi/linux#5627 kernel: gpio: brcmstb: Use dynamic GPIO base numbers See: raspberrypi/linux#5639
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 12, 2023
kernel: configs: Enable more sound devices See: raspberrypi/linux#5637 kernel: media: i2c: ov9282: Read chip ID via 2 reads See: raspberrypi/linux#5644 kernel: vc04_services: bcm2835-codec: Correct alignment requirements for YUYV See: raspberrypi/linux#5646 kernel: xhci: add quirk for host controllers that don't update endpoint DCS See: raspberrypi/linux#5642 kernel: drivers: media: rp1_cfe: Remove PISP specific MBUS formats See: raspberrypi/linux#5641 kernel: media/rpivid: Make iommu work on rpivid See: raspberrypi/linux#5627 kernel: gpio: brcmstb: Use dynamic GPIO base numbers See: raspberrypi/linux#5639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware wants the YUYV format stride alignment to be to a multiple of 32pixels / 64 bytes. The kernel driver was configuring it to a multiple of 16 pixels / 32 bytes, which then failed when it tried starting to stream.
Correct the alignment requirements.