-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick important w1 fixes #2958
Comments
Hi @manio - sorry for the delay. I've merged those patches into rpi-4.19.y, but beware - I think the first patch contains a typo. Where the code says:
Note the
Watch out for (or create - I think you are the original author) an upstream fix for this (if indeed it is an error) and we can cherry-pick that as well. |
@pelwell Regarding this patch here in the rpi kernel - please do what is more proper in your development flow. Please either fix this typo yourself during/after cherry-picking or please just apply my fix. I hope it will be merged upstream without any objections but it will surely take some time... regards! |
For back-ports we like to keep the same number of commits as appear upstream so that they are skipped without conflicts when we port our downstream patches to an upstream kernel that already includes them. If it's alright with you I'll wait until your fix is accepted, if only to get a commit hash for it. BTW Your patch should really have a "Fixes: " tag to make it clear it isn't a new feature and to ensure it is replicated everywhere the original patch ends up. |
I see. I've just posted PATCH v2 with the "Fixes" tag. I am now closing this issue and I will reply here with the commit hash when it will upstreamed :) |
Fix cherry-picked - see 1694cf0. |
Thank you! :) |
kernel rpi-4.19.y changes for common DTS+overlays kernel: Cherrypick important w1 fixes See: raspberrypi/linux#2958 kernel: usb: dwc_otg: Clean up interrupt claiming code See: raspberrypi/linux#2612 kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard See: raspberrypi/linux#2923 kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support See: raspberrypi/linux#2975 kernel: configs: Enable PIDs cgroup See: raspberrypi/linux#2968
kernel rpi-4.19.y changes for common DTS+overlays kernel: Cherrypick important w1 fixes See: raspberrypi/linux#2958 kernel: usb: dwc_otg: Clean up interrupt claiming code See: raspberrypi/linux#2612 kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard See: raspberrypi/linux#2923 kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support See: raspberrypi/linux#2975 kernel: configs: Enable PIDs cgroup See: raspberrypi/linux#2968
Having an issue with a temp sensor /sys/bus/w1/devices/28-0417c1d913ff/w1_slave ( Had to revert to 4.14.98 for now as the temp reading stays at 86 degrees celsius. After roll back now ok. |
@afullagar ps. I also can't see any recent changes in this module: |
Cherry-picked to the 4.19 tree. |
Great! Thank you! :) |
See: raspberrypi/linux#2958 firmware: 2711: CORE, EMMC & BVB clock updates for WiFi / 4Kp60 firmware: 711: Use boost instead of fixed freq for 4Kp60
See: raspberrypi/linux#2958 firmware: 2711: CORE, EMMC & BVB clock updates for WiFi / 4Kp60 firmware: 711: Use boost instead of fixed freq for 4Kp60
Hi,
@pelwell, can you please cherry-pick those three fixes which are upstreamed already?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/w1?id=49695ac46861180baf2b2b92c62da8619b6bf28f
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/w1?id=62909da8aca048ecf9fbd7e484e5100608f40a63
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/w1?id=5cb27d30fc3a281e830a2099d520b469e2b82008
It is working wrongly (w1 protocol errors) without this in certain circumstances (eg single DS2408 slave on w1 bus).
The text was updated successfully, but these errors were encountered: