media: i2c: imx477: Fix locking in imx477_init_controls()

The driver does not lock the imx477 mutex when calling imx477_set_framing_limits(), leading to: WARNING: CPU: 3 PID: 426 at drivers/media/v4l2-core/v4l2-ctrls-api.c:934 __v4l2_ctrl_modify_range+0x1a0/0x210 [ videodev] Fix this by taking the lock. Signed-off-by: Tomi Valkeinen <[email protected]>
raspberrypi · Sep 28, 2023 · 72c25bb · 72c25bb
1 parent c7cf339
commit 72c25bb
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/drivers/media/i2c/imx477.c b/drivers/media/i2c/imx477.c
@@ -2069,9 +2069,13 @@ static int imx477_init_controls(struct imx477 *imx477)
 
 	imx477->sd.ctrl_handler = ctrl_hdlr;
 
+	mutex_lock(&imx477->mutex);
+
 	/* Setup exposure and frame/line length limits. */
 	imx477_set_framing_limits(imx477);
 
+	mutex_unlock(&imx477->mutex);
+
 	return 0;
 
 error: